-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extending config breaks coverage #732
Comments
This appeared to work in a previous version (10.2.0). After upgrading to latest (11.3.0), it appears to have broken. |
from what I can tell, |
@bcoe, I submitted a pr: yargs/yargs#1080 that should take care of this. |
@genepaul I've landed your feature in yargs, and published it to the
mind trying to upgrade yargs in nyc, and if the upstream fix works for you, we can publish a new version of nyc. |
Thanks so much! I'll test it today. |
@bcoe - I tested this on a project that had been breaking when upgrading nyc, and verified that extending configs works fine now. |
@genepaul great 👍 if you'd like to submit a patch with the yargs update, so that we don't forget, I'll get it landed soon. |
Done. |
@bcoe can we please have a release for this change? |
This fix has been implemented |
Expected Behavior
Using
"extends": "./path/to/.nycrc"
should work the same as using all the configuration options in the same config.Observed Behavior
Using
"extends'
causes broken/unknown coverage - ignores any extended configsBonus Points! Code (or Repository) that Reproduces Issue
http://github.com/genepaul/nyc-test
Forensic Information
Operating System: Windows 7
Environment Information: information about your project's environment, see instructions below:
sh -c 'node --version; npm --version; npm ls' > output.txt
https://gist.github.com/genepaul/b07ab7795a89dab1cc490b5a5593e93a
The text was updated successfully, but these errors were encountered: