-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to exclude files on coverage report generation #982
Conversation
I'm not very familiar with the |
@henriquemotaesteves sorry about this, would you mind rebasing this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable to me. One question that comes to mind though, is what advantage to we get by pulling in istanbul-api
... I always felt like istanbul-api
felt like a weird abstraction, what does it add over using istanbul-report
directly, and adding the exclude logic to istanbul-report
... just wondering what the value is of the extra layer of indirection.
Not a blocker for me though, just a question -- did you find you liked the api better exposed through istanbul-api
, vs., interacting with the report module directly?
@henriquemotaesteves looking good to me once you rebase and tests pass. |
feat: add support to exclude files on coverage report generation (istanbuljs#982)
…ion (istanbuljs#982)" This reverts commit 509c6aa.
…ion (istanbuljs#982)" This reverts commit 509c6aa.
Add support to exclude files on coverage report generation (istanbuljs/istanbuljs#275) to
nyc
(#956).