feat: Add create_before_destroy lifecycle hook to security groups created (terraform-aws-modules#1985)

Author: bryantbiggs

main.tf

@@ -125,6 +125,10 @@ resource "aws_security_group" "cluster" {
     { "Name" = local.cluster_sg_name },
     var.cluster_security_group_tags
   )
+
+  lifecycle {
+    create_before_destroy = true
+  }
 }
 
 resource "aws_security_group_rule" "cluster" {

modules/eks-managed-node-group/main.tf

@@ -372,6 +372,12 @@ resource "aws_security_group" "this" {
     { "Name" = local.security_group_name },
     var.security_group_tags
   )
+
+  # https://github.com/hashicorp/terraform-provider-aws/issues/2445
+  # https://github.com/hashicorp/terraform-provider-aws/issues/9692
+  lifecycle {
+    create_before_destroy = true
+  }
 }
 
 resource "aws_security_group_rule" "this" {

modules/self-managed-node-group/main.tf

@@ -458,6 +458,12 @@ resource "aws_security_group" "this" {
     },
     var.security_group_tags
   )
+
+  # https://github.com/hashicorp/terraform-provider-aws/issues/2445
+  # https://github.com/hashicorp/terraform-provider-aws/issues/9692
+  lifecycle {
+    create_before_destroy = true
+  }
 }
 
 resource "aws_security_group_rule" "this" {

node_groups.tf

@@ -161,6 +161,10 @@ resource "aws_security_group" "node" {
     },
     var.node_security_group_tags
   )
+
+  lifecycle {
+    create_before_destroy = true
+  }
 }
 
 resource "aws_security_group_rule" "node" {