Skip to content

Commit 6d0e00c

Browse files
addaleaxitaloacasas
authored andcommitted
doc: typographical fixes in COLLABORATOR_GUIDE.md
Fix a typo and add a missing line break. PR-URL: nodejs#11163 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Nikolai Vavilov <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
1 parent 8cdd600 commit 6d0e00c

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

COLLABORATOR_GUIDE.md

+3-2
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ followed to determine which aspects of the Node.js API are considered
122122

123123
Exception to each of these points can be made if use or behavior of a given
124124
internal API can be demonstrated to be sufficiently relied upon by the Node.js
125-
ecosystem such that any changes would cause too much breakage. The threshhold
125+
ecosystem such that any changes would cause too much breakage. The threshold
126126
for what qualifies as "too much breakage" is to be decided on a case-by-case
127127
basis by the CTC.
128128

@@ -161,7 +161,8 @@ sufficient review by collaborators and approval of at least two CTC members.
161161

162162
Examples of breaking changes include, but are not necessarily limited to,
163163
removal or redefinition of existing API arguments, changing return values
164-
(except when return values do not currently exist), removing or modifying existing properties on an options argument, adding or removing errors,
164+
(except when return values do not currently exist), removing or modifying
165+
existing properties on an options argument, adding or removing errors,
165166
changing error messages in any way, altering expected timing of an event (e.g.
166167
moving from sync to async responses or vice versa), and changing the
167168
non-internal side effects of using a particular API.

0 commit comments

Comments
 (0)