Skip to content

Port dbg attribute to modern binrw #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jam1garner opened this issue Sep 9, 2021 · 1 comment
Closed

Port dbg attribute to modern binrw #50

jam1garner opened this issue Sep 9, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers has instructions The given issue contains instructions on how to fix it or otherwise contribute

Comments

@jam1garner
Copy link
Owner

The br(dbg) attribute was an attribute I proposed a while back that never actually landed on master. I would still be interested in it, and for the most part the process of porting it to work using the current codebase shouldn't actually require significant changes.

Original PR to base this off: #16

Effectively the goal is to port or reimplement the contents of the PR. If there's any trouble with it feel free to message me in the discord/matrix chat.
@jam1garner jam1garner added enhancement New feature or request good first issue Good for newcomers has instructions The given issue contains instructions on how to fix it or otherwise contribute labels Sep 9, 2021
@Swiftb0y Swiftb0y mentioned this issue Oct 4, 2022
Merged
@csnover
Copy link
Collaborator

csnover commented Oct 25, 2022

Resolved by #162.

@csnover csnover closed this as completed Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers has instructions The given issue contains instructions on how to fix it or otherwise contribute
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@csnover @jam1garner