Skip to content

Windows support #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samwgoldman opened this issue Oct 6, 2023 · 3 comments
Open

Windows support #33

samwgoldman opened this issue Oct 6, 2023 · 3 comments
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.

Comments

@samwgoldman
Copy link

Currently, re2 does not build on Windows for a few reasons. I'm opening this issue to gauge interest from the JS team and as a tracking issue for future PRs.

Known issues:

  • re2_c build rule
    • overrides CXX, but we want x86_64-w64-mingw32-g++.exe from the env
    • bash script %{make} interpolation doesn't work with Windows-style path separators, which become escape sequences in the string
  • upstream re2 code doesn't compile, needs to be updated (suggest updating to tag 2019-06-01)
@github-iron github-iron added the forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system. label Oct 9, 2023
@dwang20151005
Copy link
Contributor

Hi,

I'm opening this issue to gauge interest from the JS team and as a tracking issue for future PRs.

We're happy to take PRs!

For Windows and BSD, our policy is to merge patches but not to promise any support ourselves or to exercise it as part of our CI suite. Our internal CI has no Windows build boxes. Nor do I have a Windows dev box.

@rzabarazesh
Copy link

@dwang20151005 We have been able to add mingw support to v0.15.0 prior to the core split. It would be great if we can upstream those changes here as well but in the meantime I figured I can drop a link in case anyone else found it useful:
https://github.com/rzabarazesh/re2/tree/v0.15-mingw

@dwang20151005
Copy link
Contributor

Can you send me a pull request? That will trigger some tooling we have that makes it easier for me to import your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.
Projects
None yet
Development

No branches or pull requests

4 participants