Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEP_WEBPACK_COMPILATION_ASSETS] DeprecationWarning: Compilation.assets will be frozen in future, all modifications are deprecated. #1529

Closed
LP1994 opened this issue Oct 16, 2020 · 16 comments

Comments

@LP1994
Copy link

LP1994 commented Oct 16, 2020

Expected behaviour

When I use webpack 5, there are no warnings.

Current behaviour

When I use webpack 5, there are warnings!!!
(node:1652) [DEP_WEBPACK_COMPILATION_ASSETS] DeprecationWarning: Compilation.assets will be frozen in future, all modifications are deprecated.
BREAKING CHANGE: No more changes should happen to Compilation.assets after sealing the Compilation.
Do changes to assets earlier, e. g. in Compilation.hooks.processAssets.
Make sure to select an appropriate stage from Compilation.PROCESS_ASSETS_STAGE_*.
at G:\SNWS\sn-micro-front-web-project-template\node_modules\html-webpack-plugin\index.js:280:49
at processTicksAndRejections (internal/process/task_queues.js:93:5)

Environment

webpack version: v5.1.2
Node.js version: v14.14.0
Operating System: Windows 10
npm: v6.14.8
html-webpack-plugin: v4.5.0

Config

no

Relevant Links

no

Additional context

no

@Thebarda
Copy link

There is a related issue #1523

@jantimon
Copy link
Owner

Can you please see if this is fixed with [email protected] ?
Please see also #1527

@LP1994
Copy link
Author

LP1994 commented Oct 16, 2020

Can you please see if this is fixed with [email protected] ?
Please see also #1527

Thank you! I tried it, and then I turned it off.

@LP1994
Copy link
Author

LP1994 commented Oct 16, 2020

Can you please see if this is fixed with [email protected] ?
Please see also #1527

There is still that warning!!!
image

@jantimon
Copy link
Owner

Sorry it looks like the last release didn't include the full fix - can you please try once again with [email protected] ?

@LP1994
Copy link
Author

LP1994 commented Oct 16, 2020

Sorry it looks like the last release didn't include the full fix - can you please try once again with [email protected] ?

OK.

@LP1994
Copy link
Author

LP1994 commented Oct 16, 2020

Sorry it looks like the last release didn't include the full fix - can you please try once again with [email protected] ?

It's being tested. Wait for my good news!

@Thebarda
Copy link

[email protected] fixes the issue

@LP1994
Copy link
Author

LP1994 commented Oct 16, 2020

Sorry it looks like the last release didn't include the full fix - can you please try once again with [email protected] ?

Yes, it did. thank you! The author's timely repair.

@LP1994
Copy link
Author

LP1994 commented Oct 16, 2020

[email protected] fixes the issue

Yes, it did. thank you! The author's timely repair.

@LP1994
Copy link
Author

LP1994 commented Oct 16, 2020

This issue will also be closed.

@LP1994 LP1994 closed this as completed Oct 16, 2020
@LP1994
Copy link
Author

LP1994 commented Oct 16, 2020

Sorry it looks like the last release didn't include the full fix - can you please try once again with [email protected] ?

Looking forward to the update of the official version.

@slavafomin
Copy link

So, when are you planning to release the html-webpack-plugin@5 version?

@jkiss
Copy link

jkiss commented Feb 4, 2021

[email protected] has released!!!

@jfoclpf
Copy link

jfoclpf commented Oct 20, 2021

I have v 5.4.0 and I still have the warning:

PS C:\Users\JO52900\Desktop\develop\outlook-addin> npm show html-webpack-plugin version
5.4.0

PS C:\Users\JO52900\Desktop\develop\outlook-addin> npm run build:dev

> [email protected] build:dev C:\Users\JO52900\Desktop\develop\outlook-addin
> webpack --mode development

NODE_ENV: development
(node:39732) [DEP_WEBPACK_COMPILATION_ASSETS] DeprecationWarning: Compilation.assets will be frozen in future, all modifications are deprecated.
BREAKING CHANGE: No more changes should happen to Compilation.assets after sealing the Compilation.
        Do changes to assets earlier, e. g. in Compilation.hooks.processAssets.
        Make sure to select an appropriate stage from Compilation.PROCESS_ASSETS_STAGE_*.
assets by path *.gif 6.84 KiB
  asset ckt-128x128.gif 3.2 KiB [emitted] [from: assets/ckt-128x128.gif] (auxiliary name: taskpane)
  asset ckt-32x32.gif 1.24 KiB [emitted] [from: assets/ckt-32x32.gif] (auxiliary name: taskpane)
  asset ckt-64x64.gif 1.18 KiB [emitted] [from: assets/ckt-64x64.gif] (auxiliary name: taskpane)
  asset ckt.gif 1.18 KiB [emitted] [from: assets/ckt.gif] (auxiliary name: taskpane)
  asset 7241db16bf688bdd6dd3.gif 51 bytes [emitted] [immutable] [from: assets/ckt.gif]
assets by path *.js 468 KiB
  asset polyfill.js 460 KiB [emitted] (name: polyfill) 1 related asset
  asset taskpane.js 8.59 KiB [emitted] (name: taskpane) 1 related asset
assets by path *.css 2.62 KiB
  asset taskpane.css 1.48 KiB [emitted]
  asset 6017e634fec619e7858f.css 1.14 KiB [emitted] [immutable] [from: src/taskpane/taskpane.css]
asset taskpane.html 2.32 KiB [emitted]
runtime modules 1.72 KiB 5 modules
modules by path ./node_modules/@babel/polyfill/node_modules/core-js/modules/*.js 190 KiB 273 modules
modules by path ./node_modules/@babel/polyfill/node_modules/core-js/library/ 6.43 KiB 18 modules
modules by path ./node_modules/@babel/polyfill/node_modules/core-js/fn/ 1.29 KiB 11 modules
modules by path ./assets/*.gif 224 bytes 4 modules
modules by path ./node_modules/@babel/polyfill/lib/*.js 1.22 KiB
  ./node_modules/@babel/polyfill/lib/index.js 686 bytes [built] [code generated]
  ./node_modules/@babel/polyfill/lib/noConflict.js 567 bytes [built] [code generated]
./src/taskpane/taskpane.js 1.72 KiB [built] [code generated]
./node_modules/@babel/polyfill/node_modules/core-js/es6/index.js 5.78 KiB [built] [code generated]
./node_modules/@babel/polyfill/node_modules/core-js/web/index.js 157 bytes [built] [code generated]
./node_modules/regenerator-runtime/runtime.js 24.3 KiB [built] [code generated]
webpack 5.59.0 compiled successfully in 4038 ms
PS C:\Users\JO52900\Desktop\develop\outlook-addin>

@jantimon
Copy link
Owner

@jfoclpf this is not caused by the html-webpack-plugin 5.x

Repository owner locked as resolved and limited conversation to collaborators Oct 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants