Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fr: add support for the web: prefix. #301

Closed
achtan opened this issue May 31, 2024 · 8 comments
Closed

fr: add support for the web: prefix. #301

achtan opened this issue May 31, 2024 · 8 comments

Comments

@achtan
Copy link

achtan commented May 31, 2024

Hi, we are using this lib in our monorepo from which we are building rn native apps but also web pages.

for example when we use the class self-center we see warnings that this class is not supported in native.
We could fix this with web:self-center .

@jaredh159
Copy link
Owner

hi, thanks for opening the issue. is the thought here that web: would just turn the utility into a no-op with no warning on the native platform?

@achtan
Copy link
Author

achtan commented Jun 3, 2024

Yes, exactly!

@aretrace
Copy link

aretrace commented Jun 7, 2024

A web: prefix would be a great addition for expo/RNW projects.

@jaredh159
Copy link
Owner

yeah, agreed, if anyone wants to PR this, that would be welcome, otherwise I should be able to get to it within a few weeks 👍

@jaredh159
Copy link
Owner

hey there, i went to work on support for this today, and ... I'm pretty sure it already works. see 3bcfce3

did you actually try something like web:self-center or web:not-valid-nope? it should not warn you

(on another note: self-center is a supported RN native utility as well, you shouldn't have gotten warnings about it)

@jaredh159
Copy link
Owner

ok, well reopen if i'm missing something, but i'm pretty sure this already works, so closing 👍

@kale5195
Copy link

@jaredh159 doesn't work for web:hover:bg-red-500 ?

@jaredh159
Copy link
Owner

@jaredh159 doesn't work for web:hover:bg-red-500 ?

:hover is not a supported modifier in this library, that's a web only thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants