Skip to content

add #nomad/env-format #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
martintrojer opened this issue Sep 2, 2015 · 2 comments · Fixed by #24
Closed

add #nomad/env-format #23

martintrojer opened this issue Sep 2, 2015 · 2 comments · Fixed by #24

Comments

@martintrojer
Copy link
Contributor

Very useful to be able to construct strings inside a config file.

#nomad/env-format ["http://%s:%s/api/1.0" API_HOST API_PORT]

See #envf here;

https://github.com/juxt/joplin#hiding-secrets-from-the-configuration-map

@jarohen
Copy link
Owner

jarohen commented Sep 2, 2015

Hi Martin, yes - agreed!

If Joplin calls it #envf, I'm happy to call it #nomad/envf too. I'm afraid I don't have a lot of time outside work at the moment, so it might be a while coming, unless you could submit a PR?

Cheers,

James

@martintrojer
Copy link
Contributor Author

raised a PR.

called it env-format since I though it was more in line with existing nomad reader tag names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants