fix(keymaps) stronger specifity of build and go to declaration commands

ref TypeStrong#145
closes TypeStrong#139

Author: basarat

keymaps/atom-typescript.cson

@@ -1,10 +1,19 @@
 'atom-text-editor[data-grammar~=ts]':
   'alt-cmd-l': 'typescript:format-code'
   'alt-ctrl-l': 'typescript:format-code'
-  'ctrl-shift-b': 'typescript:build'
-  'cmd-shift-b': 'typescript:build'
-  'ctrl-b': 'typescript:go-to-declaration'
-  'cmd-b': 'typescript:go-to-declaration'
   'ctrl-;': 'typescript:context-actions'
   'cmd-;': 'typescript:context-actions'
   'f2': 'typescript:rename-variable'
+
+# Note that we are good citizens in our commands handling logic
+# we will gladly hand off the command to something else if a ts file is not active
+# That said : 
+# These need to be *platform specific* + on *body* to increase specifity + we need to have a menu item for these 
+# if we want them to override what atom has by default (find buffer / find modified file)
+'body.platform-win32, body.platform-linux':
+  'ctrl-shift-b': 'typescript:build'
+  'ctrl-b': 'typescript:go-to-declaration'
+'body.platform-darwin':
+  'cmd-shift-b': 'typescript:build'
+  'cmd-b': 'typescript:go-to-declaration'
+

lib/main/atom/commands.js

@@ -39,7 +39,7 @@ function registerCommands() {
             });
         }
     });
-    atom.commands.add('atom-text-editor', 'typescript:build', function (e) {
+    atom.commands.add('atom-workspace', 'typescript:build', function (e) {
         if (!commandForTypeScript(e))
             return;
         var editor = atom.workspace.getActiveTextEditor();
@@ -68,7 +68,7 @@ function registerCommands() {
             });
         });
     };
-    atom.commands.add('atom-text-editor', 'typescript:go-to-declaration', handleGoToDeclaration);
+    atom.commands.add('atom-workspace', 'typescript:go-to-declaration', handleGoToDeclaration);
     atom.commands.add('atom-text-editor', 'symbols-view:go-to-declaration', handleGoToDeclaration);
     atom.commands.add('atom-text-editor', 'typescript:context-actions', function (e) {
         atom.notifications.addSuccess('Context options coming soon!');

lib/main/atom/commands.ts

@@ -52,7 +52,7 @@ export function registerCommands() {
 
         }
     });
-    atom.commands.add('atom-text-editor', 'typescript:build',(e) => {
+    atom.commands.add('atom-workspace', 'typescript:build',(e) => {
         if (!commandForTypeScript(e)) return;
 
         var editor = atom.workspace.getActiveTextEditor();
@@ -91,7 +91,7 @@ export function registerCommands() {
         });
     };
 
-    atom.commands.add('atom-text-editor', 'typescript:go-to-declaration', handleGoToDeclaration);
+    atom.commands.add('atom-workspace', 'typescript:go-to-declaration', handleGoToDeclaration);
     // This exists by default in the right click menu https://github.com/TypeStrong/atom-typescript/issues/96
     atom.commands.add('atom-text-editor', 'symbols-view:go-to-declaration', handleGoToDeclaration);
 

lib/main/atom/views/mainPanelView.js

@@ -29,7 +29,7 @@ var MainPanelView = (function (_super) {
             }, text);
         };
         this.div({
-            class: 'am-panel tool-panel panel-bottom native-key-bindings',
+            class: 'am-panel tool-panel panel-bottom native-key-bindings atomts-main-panel',
             tabindex: '-1'
         }, function () {
             _this.div({

lib/main/atom/views/mainPanelView.ts

@@ -28,7 +28,7 @@ export class MainPanelView extends view.View<any> {
             }, text);
 
         this.div({
-            class: 'am-panel tool-panel panel-bottom native-key-bindings',
+            class: 'am-panel tool-panel panel-bottom native-key-bindings atomts-main-panel',
             tabindex: '-1'
         },() => {
                 this.div({

menus/atomts-menus.cson

@@ -0,0 +1,13 @@
+# See https://atom.io/docs/latest/creating-a-package#menus for more details
+'menu': [
+  {
+    'label': 'Packages'
+    'submenu': [
+      'label': 'TypeScript'
+      'submenu': [
+        { 'label': 'Build', 'command': 'typescript:build' }
+        { 'label': 'Go To Declaration', 'command': 'typescript:go-to-declaration' }
+      ]
+    ]
+  }
+]