Update extension shim, remove unused constants

Author: jbboehr

Diff for: compat/BaseImpl.php

@@ -2,6 +2,8 @@
 
 namespace Handlebars;
 
+use Psr\Log\LoggerInterface;
+
 abstract class BaseImpl implements Impl
 {
     /**
@@ -19,6 +21,11 @@ abstract class BaseImpl implements Impl
      */
     protected $decorators;
 
+    /**
+     * @var LoggerInterface
+     */
+    protected $logger;
+
     /**
      * @return Registry
      */
@@ -43,27 +50,51 @@ public function getPartials()
         return $this->partials;
     }
 
+    /**
+     * @return LoggerInterface
+     */
+    public function getLogger()
+    {
+        return $this->logger;
+    }
+
     /**
      * @param Registry $helpers
+     * @return $this
      */
     public function setHelpers(Registry $helpers)
     {
         $this->helpers = $helpers;
+        return $this;
     }
 
     /**
      * @param Registry $partials
+     * @return $this
      */
     public function setPartials(Registry $partials)
     {
         $this->partials = $partials;
+        return $this;
     }
 
     /**
      * @param Registry $decorators
+     * @return $this
      */
     public function setDecorators(Registry $decorators)
     {
         $this->decorators = $decorators;
+        return $this;
+    }
+
+    /**
+     * @param LoggerInterface $logger
+     * @return $this
+     */
+    public function setLogger(LoggerInterface $logger)
+    {
+        $this->logger = $logger;
+        return $this;
     }
 }

Diff for: compat/Impl.php

@@ -2,21 +2,22 @@
 
 namespace Handlebars;
 
+use Psr\Log\LoggerInterface;
+use Psr\Log\LoggerAwareInterface;
+
 /**
  * Note: this class is only used when the extension isn't loaded
  */
-interface Impl
+interface Impl extends LoggerAwareInterface
 {
-    const MODE_COMPILER = 'compiler';
-    const MODE_VM = 'vm';
-    const MODE_CVM = 'cvm';
-
     public function getHelpers();
     public function getPartials();
     public function getDecorators();
+    public function getLogger();
     public function setHelpers(Registry $helpers);
     public function setPartials(Registry $partials);
     public function setDecorators(Registry $decorators);
+    public function setLogger(LoggerInterface $logger);
     public function render($tmpl, $context = null, array $options = null);
     public function renderFile($filename, $context = null, array $options = null);
 }

Diff for: tests/HandlebarsTest.php

@@ -37,9 +37,7 @@ public function testCompileThrowsExceptionWithInvalidTemplate1()
 
     public function testCompilerRenderMode()
     {
-        $handlebars = new Handlebars(array(
-            'mode' => Handlebars::MODE_COMPILER,
-        ));
+        $handlebars = new Handlebars();
         $this->assertEquals('bar', $handlebars->render('{{foo}}', array(
             'foo' => 'bar',
         )));
@@ -81,7 +79,7 @@ public function testRenderSupportsStdClass()
 
     public function testRenderFile()
     {
-        $handlebars = new Handlebars(array('mode' => Handlebars::MODE_CVM));
+        $handlebars = new \Handlebars\VM();
         $this->assertEquals('bar', $handlebars->renderFile(__DIR__ . '/fixture1.hbs', array('foo' => 'bar')));
     }