Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work in the browser #12

Open
jbrooksuk opened this issue Feb 11, 2014 · 5 comments
Open

Work in the browser #12

jbrooksuk opened this issue Feb 11, 2014 · 5 comments

Comments

@jbrooksuk
Copy link
Owner

Apart from the require function being called to load lodash, there is no real reason that prevents node-summary from running in the browser.

@jbrooksuk
Copy link
Owner Author

This can be implemented in the same way I've started writing Affair. It'll need a slight rewrite of the library, hopefully without breaking backwards compatibility.

@jbrooksuk
Copy link
Owner Author

This has now been started and seems to work without errors, although the summarised text is different?

It currently depends on Underscore/Lo-dash however I think I could remove these dependencies by including them within the Toolkit object.

@jbrooksuk
Copy link
Owner Author

I forgot to add that the test suite does pass, and it does work in the browser. Once the dependencies have been removed and the code has been improved I should be ok to merge this.

@oa495
Copy link

oa495 commented Feb 16, 2018

Would I be able to use this as is? @jbrooksuk

@justinmchase
Copy link

I don't understand why you have to have a browser / non-browser version. Just remove summarizeFromUrl and then transpile it into es5 compatible code before packaging and that should do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants