Skip to content

Commit 67947f3

Browse files
committed
Fix some issues caused by moving to C++ bindings
1 parent ecd47dd commit 67947f3

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

src/post-worker.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ self.blendRenderTiming = function (timing, force) {
208208
var renderResult = self.octObj.renderBlend(self.getCurrentTime() + self.delay, force);
209209
var blendTime = renderResult.blend_time;
210210
var canvases = [], buffers = [];
211-
if (renderResult && (renderResult.changed != 0 || force)) {
211+
if (renderResult.ptr != 0 && (renderResult.changed != 0 || force)) {
212212
// make a copy, as we should free the memory so subsequent calls can utilize it
213213
var result = new Uint8Array(HEAPU8.subarray(renderResult.image, renderResult.image + renderResult.dest_width * renderResult.dest_height * 4));
214214

src/subtitles-octopus.js

+4-6
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ var SubtitlesOctopus = function (options) {
1616
self.renderMode = options.renderMode || (options.lossyRender ? 'fast' : (options.blendRender ? 'blend' : 'normal'));
1717
self.libassMemoryLimit = options.libassMemoryLimit || 0; // set libass bitmap cache memory limit in MiB (approximate)
1818
self.libassGlyphLimit = options.libassGlyphLimit || 0; // set libass glyph cache memory limit in MiB (approximate)
19-
self.targetFps = options.targetFps || undefined;
19+
self.targetFps = options.targetFps || 30;
2020
self.renderAhead = options.renderAhead || 0; // how many MiB to render ahead and store; 0 to disable (approximate)
2121
self.isOurCanvas = false; // (internal) we created canvas and manage it
2222
self.video = options.video; // HTML video element (optional if canvas specified)
@@ -570,11 +570,9 @@ var SubtitlesOctopus = function (options) {
570570
size += item.buffer.byteLength;
571571
}
572572
if ((data.emptyFinish > 0 && data.emptyFinish - data.eventStart < 1.0 / self.targetFps) || data.animated) {
573-
newFinish = data.eventStart + 1.0 / self.targetFps;
574-
if (newFinish < data.emptyFinish) {
575-
data.emptyFinish = newFinish;
576-
data.eventFinish = (data.eventFinish > newFinish) ? newFinish : data.eventFinish;
577-
}
573+
var newFinish = data.eventStart + 1.0 / self.targetFps;
574+
data.emptyFinish = newFinish;
575+
data.eventFinish = (data.eventFinish > newFinish) ? newFinish : data.eventFinish;
578576
}
579577
self.renderedItems.push({
580578
eventStart: data.eventStart,

0 commit comments

Comments
 (0)