Skip to content

Commit 884f71d

Browse files
authored
Use plugin bom version prior to trilead API upgrade (#212)
The plugin compatibility tester mistakenly uses the version of optional plugins that is provided by the pom of the tested plugin rather than using the version of plugin that is listed in the pom file of the plugin bill of materials. Because of that issue, the 2.426.x plugin bill of materials version needs to remain on an older version in order to not include an optional dependency on a newer version of the trilead API plugin. 3080.vfa_b_e4a_a_39b_44 is the version immediately before a trilean API plugin upgrade in the BOM. jenkinsci/bom#3404 has more details #211 includes some discussion as well.
1 parent e5af1db commit 884f71d

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

pom.xml

+5-1
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,11 @@
9393
<dependency>
9494
<groupId>io.jenkins.tools.bom</groupId>
9595
<artifactId>bom-2.426.x</artifactId>
96-
<version>3208.vb_21177d4b_cd9</version>
96+
<!-- Last 2.426.x BOM version before a trilead api upgrade -->
97+
<!-- Trilead API upgrade breaks plugin compatibility tests due to poor handling of optional dependencies -->
98+
<!-- Do not change this without checking plugin BOM passes with new version -->
99+
<!-- https://github.com/jenkinsci/bom/pull/3404 -->
100+
<version>3080.vfa_b_e4a_a_39b_44</version>
97101
<scope>import</scope>
98102
<type>pom</type>
99103
</dependency>

0 commit comments

Comments
 (0)