fix(formatCardNumber): fix issue where duplicate digits were added to

number

Author: jessepollak

dist/payment.js

@@ -226,14 +226,10 @@ var payment =
 	  }
 	  for (i = j = 0, len = upperLengths.length; j < len; i = ++j) {
 	    upperLength = upperLengths[i];
-	    if (length > upperLength && upperLengths[i + 1]) {
+	    if (length >= upperLength && upperLengths[i + 1]) {
 	      continue;
 	    }
-	    if (length > upperLength) {
-	      return;
-	    }
-	    if (length === upperLength) {
-	      QJ.val(target, value + digit);
+	    if (length >= upperLength) {
 	      return;
 	    }
 	  }
@@ -249,10 +245,6 @@ var payment =
 	    e.preventDefault();
 	    QJ.val(target, value + ' ' + digit);
 	    return QJ.trigger(target, 'change');
-	  } else if (re.test(value + digit)) {
-	    e.preventDefault();
-	    QJ.val(target, value + digit + ' ');
-	    return QJ.trigger(target, 'change');
 	  }
 	};
 

spec/index.spec.coffee

@@ -307,7 +307,7 @@ describe 'payment', ->
       ev = document.createEvent "HTMLEvents"
       ev.initEvent "keypress", true, true
       ev.eventName = "keypress"
-      ev.which = 52
+      ev.which = "4".charCodeAt(0)
 
       number.dispatchEvent(ev)
 
@@ -412,22 +412,6 @@ describe 'payment', ->
       number.dispatchEvent(ev)
 
       assert.equal QJ.val(number), '4111 1111 1111 1111 1'
-    it 'should format cc number correctly when a lesser length limit is reached', ->
-      number = document.createElement('input')
-      number.type = 'text'
-      QJ.val(number, '4111 1111 1111 111')
-
-      Payment.formatCardNumber(number)
-
-      ev = document.createEvent "HTMLEvents"
-      ev.initEvent "keypress", true, true
-      ev.eventName = "keypress"
-      ev.which = "1".charCodeAt(0)
-
-      number.dispatchEvent(ev)
-      
-      assert.equal QJ.val(number), '4111 1111 1111 1111'
-
   describe 'formatCardExpiry', ->
     it 'should add a slash after two numbers', ->
       expiry = document.createElement('input')

src/index.coffee

@@ -162,11 +162,8 @@ formatCardNumber = (e) ->
 
   # Return if an upper length has been reached
   for upperLength, i in upperLengths
-    continue if length > upperLength and upperLengths[i+1]
-    return if length > upperLength
-    if length == upperLength
-      QJ.val(target, value + digit)
-      return
+    continue if length >= upperLength and upperLengths[i+1]
+    return if length >= upperLength
 
   # Return if focus isn't at the end of the text
   return if hasTextSelected(target)
@@ -183,12 +180,6 @@ formatCardNumber = (e) ->
     QJ.val(target, value + ' ' + digit)
     QJ.trigger(target, 'change')
 
-  # If '424' + 2
-  else if re.test(value + digit)
-    e.preventDefault()
-    QJ.val(target, value + digit + ' ')
-    QJ.trigger(target, 'change')
-
 formatBackCardNumber = (e) ->
   target = e.target
   value   = QJ.val(target)