Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback location to redshift.conf #348

Open
jetojedno opened this issue Jun 18, 2016 · 11 comments
Open

Add fallback location to redshift.conf #348

jetojedno opened this issue Jun 18, 2016 · 11 comments

Comments

@jetojedno
Copy link

If geoclue fails, redshift fails. That's wrong. There should be the ability to add a fallback (or default) location which is used if geoclue doesn't return a location.

See issue #333

@maandree
Copy link
Contributor

I think these should be address in GeoClue. That way it is solved for all applications that use GeoClue.

I also suggest using ~/.config/geolocation for this.

@jetojedno
Copy link
Author

Rejected https://bugs.freedesktop.org/show_bug.cgi?id=96839

They explain that it would break other applications which use GeoClue. Preferred solution is for redshift to store (somewhere) the last known good location, and use that if GeoClue returns nothing.

@maandree
Copy link
Contributor

maandree commented Jul 7, 2016

What? Couldn't you just tell GeoClue that you are fine with a fallback or last known location?

@jtarin47
Copy link

jtarin47 commented Jul 8, 2016

"redshift.config" is the most direct approach. Set it and forget it. Only drawback is if your a frequent long-distance traveler.

@jetojedno
Copy link
Author

@maandree funnily, I don't think I'm in a position to tell the developers / maintainers / architects of a package what to do with their package. I can request / suggest changes, but they take responsibility for the system and and changes. The same with redshift.
@jtarin47 I do travel a lot. Most of the time I have internet once or twice a day ...

Having a separate request (or separate part of the response) where GeoClue provides that last known good location would work on both sides. Using the new info would require changes to redshift, but any acceptable solution is going to.

@jetojedno
Copy link
Author

@jtarin47 that solution doesn't work if you travel a lot, as I do. If you're (relatively) static then you don't need GeoClue at all.

@maandree I've requested a satisfactory compromise https://bugs.freedesktop.org/show_bug.cgi?id=96861

@ksinkar
Copy link

ksinkar commented Aug 31, 2017

I think a better way would be use the TimeZone locale to be used of GeoClue is not available or disabled. Each timezone is always passes through a city and if you are in that timezone, it approximates your day-night cycle. And every Linux machine always has a timezone associated with it. If you travel a lot, then you could simply put your timezone on autosync mode and it would still solve your problem.

@ksinkar
Copy link

ksinkar commented Aug 31, 2017

I think a third location provider can be added called system-timezone which can solve this problem. So people can choose to that. Also this should be the default, because system-timezone shall always be present whether geoclue is present or not. System Timezone is always there on the OS.

@rugk
Copy link

rugk commented Aug 31, 2017

But it makes a difference if you are in the same timezone near the equator or near the north or south pole.

@ksinkar
Copy link

ksinkar commented Aug 31, 2017

@rugk, I agree with you. system-timezone is definitely not a silver bullet that solves all the problems. If someone is not okay with using system-timezone, they can always go for Geoclue or manual setting, but for the program to start and then crash because Geoclue has not been enabled can be a big turnoff for first-time users. The program should just run when it starts, with sensible defaults and without any configuration required or for anyone to come here and read the README. Once the program has started a user should be able to customise the program to his or her own preferences. But if the program fails on startup itself, users will think it is a buggy FLOSS and simply not use it.

system-timezone is a sensible default; nothing more and nothing less.

@mirh
Copy link

mirh commented Jun 24, 2019

Isn't this the same of #36?
Also, geoclue issue moved here now
https://gitlab.freedesktop.org/geoclue/geoclue/issues/51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants