Skip to content

Commit 3a0876d

Browse files
Make HTMLColDiff properly show differences for non-numeric fields, it used to
output the original value twice. Make HTMLColDiff mark tests that compiled before but are now failing with "FAIL" and highlight them. llvm-svn: 52533
1 parent 6969c87 commit 3a0876d

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

HTMLColDiff.pl

+10-3
Original file line numberDiff line numberDiff line change
@@ -161,10 +161,17 @@
161161
}
162162

163163
} elsif ($Field ne $FieldComp) {
164-
# Always show but never highlight changes in non-numeric
165-
# fields
166164
$Show = 1;
167-
$Field = "$FieldComp => $FieldComp";
165+
# Specially handle tests that are failing to compile but were not
166+
# doing so previously
167+
if ($Field eq "*") {
168+
$Highlight = 1;
169+
$Colour = "red";
170+
$Field = "FAIL";
171+
}
172+
# Always show but never highlight other changes in non-numeric
173+
# fields
174+
$Field = "$FieldComp => $Field";
168175
}
169176
}
170177
# Remove spaces, we don't want wrapping inside cells

0 commit comments

Comments
 (0)