Merge pull request schmittjoh#302 from goetas/xmlbooleans

Unserialization of XML booleans

Author: schmittjoh

Diff for: src/JMS/Serializer/XmlDeserializationVisitor.php

@@ -104,12 +104,12 @@ public function visitBoolean($data, array $type, Context $context)
     {
         $data = (string) $data;
 
-        if ('true' === $data) {
+        if ('true' === $data || '1' === $data) {
             $data = true;
-        } elseif ('false' === $data) {
+        } elseif ('false' === $data || '0' === $data) {
             $data = false;
         } else {
-            throw new RuntimeException(sprintf('Could not convert data to boolean. Expected "true", or "false", but got %s.', json_encode($data)));
+            throw new RuntimeException(sprintf('Could not convert data to boolean. Expected "true", "false", "1" or "0", but got %s.', json_encode($data)));
         }
 
         if (null === $this->result) {
@@ -224,9 +224,9 @@ public function visitProperty(PropertyMetadata $metadata, $data, Context $contex
                 $nodes = $data->xpath('./@'.$attributeName);
                 if (!empty($nodes)) {
                     $v = (string) reset($nodes);
-                    $metadata->reflection->setValue($this->currentObject, $v);    
+                    $metadata->reflection->setValue($this->currentObject, $v);
                 }
-                
+
             } elseif (isset($data[$name])) {
                 $v = $this->navigator->accept($data[$name], $metadata->type, $context);
                 $metadata->reflection->setValue($this->currentObject, $v);

Diff for: tests/JMS/Serializer/Tests/Serializer/XmlSerializationTest.php

@@ -47,6 +47,22 @@ public function testInvalidUsageOfXmlValue()
         $this->serialize($obj);
     }
 
+
+    /**
+     * @dataProvider getXMLBooleans
+     */
+    public function testXMLBooleans($xmlBoolean, $boolean)
+    {
+        if ($this->hasDeserializer()) {
+            $this->assertSame($boolean, $this->deserialize('<result>'.$xmlBoolean.'</result>', 'boolean'));
+        }
+    }
+
+    public function getXMLBooleans()
+    {
+        return array(array('true', true), array('false', false), array('1', true), array('0', false));
+    }
+
     public function testPropertyIsObjectWithAttributeAndValue()
     {
         $personCollection = new PersonLocation;