Skip to content

Commit 4750a96

Browse files
authored
Merge pull request #682 from auth0-developer-hub/fix/tippy-top-banner-not-closing-on-other-pages
Fix: Tippy Top Banner not closing on other pages
2 parents a5bad2f + 66cfebc commit 4750a96

File tree

6 files changed

+31
-20
lines changed

6 files changed

+31
-20
lines changed

src/website/dom-elements-common.js

+9-2
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,9 @@
1-
export const codeElements = document.querySelectorAll('.plain-text pre code');
2-
export const counterElement = document.querySelector('.counter');
1+
export const codeElements = document.querySelectorAll(".plain-text pre code");
2+
export const counterElement = document.querySelector(".counter");
3+
4+
export const navbarElement = document.querySelector("nav.navbar");
5+
export const menuTriggerElement = document.querySelector(".menu-trigger");
6+
export const menuLinks = document.querySelectorAll(".navbar .menu a");
7+
export const menuScrollableLinks = navbarElement.querySelectorAll("a.scrollto");
8+
9+
export const sectionElements = document.getElementsByTagName("section");

src/website/dom-elements.js

+1-9
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,6 @@
11
export * from '../dom-elements.js';
22
export * from './dom-elements-common.js';
33

4-
export const navbarElement = document.querySelector('nav.navbar');
5-
export const menuTriggerElement = document.querySelector('.menu-trigger');
6-
export const menuLinks = document.querySelectorAll('.navbar .menu a');
7-
export const menuScrollableLinks =
8-
navbarElement.querySelectorAll('a.scrollto');
9-
10-
export const sectionElements = document.getElementsByTagName('section');
11-
124
export const extensionSection = document.querySelector('.update-site');
135
export const ebookSection = document.querySelector('.jtw-ebook-banner');
146

@@ -22,4 +14,4 @@ export const debuggerSection = document.getElementById('debugger-io');
2214
export const shareJwtButton = document.querySelector('.website-share button');
2315
export const shareJwtTextElement = shareJwtButton.querySelector('span');
2416

25-
export const starsElements = document.getElementsByClassName('stars');
17+
export const starsElements = document.getElementsByClassName('stars');

src/website/introduction/index.js

+7-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
1-
import { setupHighlighting } from "../highlighting.js";
1+
import { CCPAModal } from "../ccpa-modal.js";
22
import { setupJwtCounter } from "../counter.js";
3+
import { setupHighlighting } from "../highlighting.js";
4+
import { setupNavbar } from "../navbar.js";
5+
import { TopBanner } from "../top-banner.js";
36

47
// Initialization
8+
setupNavbar();
59
setupHighlighting();
610
setupJwtCounter();
11+
CCPAModal();
12+
TopBanner();

src/website/libraries/index.js

+9-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,14 @@
1-
import { setupLibraries } from "./libraries.js";
2-
import { setupHighlighting } from "../highlighting.js";
1+
import { CCPAModal } from "../ccpa-modal.js";
32
import { setupJwtCounter } from "../counter.js";
3+
import { setupHighlighting } from "../highlighting.js";
4+
import { setupNavbar } from "../navbar.js";
5+
import { TopBanner } from "../top-banner.js";
6+
import { setupLibraries } from "./libraries.js";
47

58
// Initialization
9+
setupNavbar();
610
setupLibraries();
711
setupHighlighting();
8-
setupJwtCounter();
12+
setupJwtCounter();
13+
CCPAModal();
14+
TopBanner();

src/website/navbar.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import { getOffsetBoundingClientRect } from './utils.js';
22

3-
import {
3+
import {
44
navbarElement,
55
menuTriggerElement,
66
menuLinks,
77
sectionElements,
88
menuScrollableLinks
9-
} from './dom-elements.js';
9+
} from './dom-elements-common.js';
1010

1111
export function setupNavbar() {
1212
window.addEventListener('scroll', () => {
@@ -50,4 +50,4 @@ export function setupNavbar() {
5050
document.body.classList.remove('menu-mobile');
5151
});
5252
});
53-
}
53+
}

src/website/smooth-scrolling.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { menuScrollableLinks, navbarElement } from './dom-elements.js';
1+
import { menuScrollableLinks, navbarElement } from './dom-elements-common.js';
22
import { isWideScreen } from '../utils.js';
33

44
import $ from 'jquery';
@@ -9,7 +9,7 @@ import log from 'loglevel';
99
// jQuery somewhere else.
1010
export function smoothScrollTo(element) {
1111
// TODO: don't use jQuery
12-
12+
1313
const navHeight = $(navbarElement).height();
1414
const targetElement = $(element);
1515

0 commit comments

Comments
 (0)