Skip to content

Commit 85ee212

Browse files
committed
Simplify assertions
1 parent c704713 commit 85ee212

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

platform-tests/src/test/java/org/junit/platform/engine/UniqueIdTests.java

+11-10
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
import static org.assertj.core.api.Assertions.assertThat;
1414
import static org.junit.jupiter.api.Assertions.assertEquals;
1515
import static org.junit.jupiter.api.Assertions.assertFalse;
16+
import static org.junit.jupiter.api.Assertions.assertNotEquals;
1617
import static org.junit.jupiter.api.Assertions.assertSame;
1718
import static org.junit.jupiter.api.Assertions.assertThrows;
1819
import static org.junit.jupiter.api.Assertions.assertTrue;
@@ -174,8 +175,8 @@ void sameEnginesAreEqual() {
174175
var id1 = UniqueId.root("engine", "junit-jupiter");
175176
var id2 = UniqueId.root("engine", "junit-jupiter");
176177

177-
assertTrue(id1.equals(id2));
178-
assertTrue(id2.equals(id1));
178+
assertEquals(id2, id1);
179+
assertEquals(id1, id2);
179180
assertEquals(id1.hashCode(), id2.hashCode());
180181
}
181182

@@ -184,17 +185,17 @@ void differentEnginesAreNotEqual() {
184185
var id1 = UniqueId.root("engine", "junit-vintage");
185186
var id2 = UniqueId.root("engine", "junit-jupiter");
186187

187-
assertFalse(id1.equals(id2));
188-
assertFalse(id2.equals(id1));
188+
assertNotEquals(id2, id1);
189+
assertNotEquals(id1, id2);
189190
}
190191

191192
@Test
192193
void uniqueIdWithSameSegmentsAreEqual() {
193194
var id1 = UniqueId.root("engine", "junit-jupiter").append("t1", "v1").append("t2", "v2");
194195
var id2 = UniqueId.root("engine", "junit-jupiter").append("t1", "v1").append("t2", "v2");
195196

196-
assertTrue(id1.equals(id2));
197-
assertTrue(id2.equals(id1));
197+
assertEquals(id2, id1);
198+
assertEquals(id1, id2);
198199
assertEquals(id1.hashCode(), id2.hashCode());
199200
}
200201

@@ -203,17 +204,17 @@ void differentOrderOfSegmentsAreNotEqual() {
203204
var id1 = UniqueId.root("engine", "junit-jupiter").append("t2", "v2").append("t1", "v1");
204205
var id2 = UniqueId.root("engine", "junit-jupiter").append("t1", "v1").append("t2", "v2");
205206

206-
assertFalse(id1.equals(id2));
207-
assertFalse(id2.equals(id1));
207+
assertNotEquals(id2, id1);
208+
assertNotEquals(id1, id2);
208209
}
209210

210211
@Test
211212
void additionalSegmentMakesItNotEqual() {
212213
var id1 = UniqueId.root("engine", "junit-jupiter").append("t1", "v1");
213214
var id2 = id1.append("t2", "v2");
214215

215-
assertFalse(id1.equals(id2));
216-
assertFalse(id2.equals(id1));
216+
assertNotEquals(id2, id1);
217+
assertNotEquals(id1, id2);
217218
}
218219
}
219220

0 commit comments

Comments
 (0)