Skip to content

Commit de78cbf

Browse files
authored
Update typing and warning handling (#1174)
1 parent 39326fe commit de78cbf

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

jupyter_server/services/events/handlers.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,11 @@ def open(self):
5555
"""Routes events that are emitted by Jupyter Server's
5656
EventBus to a WebSocket client in the browser.
5757
"""
58-
self.event_logger.add_listener(listener=self.event_listener) # type:ignore[arg-type]
58+
self.event_logger.add_listener(listener=self.event_listener)
5959

6060
def on_close(self):
6161
"""Handle a socket close."""
62-
self.event_logger.remove_listener(listener=self.event_listener) # type:ignore[arg-type]
62+
self.event_logger.remove_listener(listener=self.event_listener)
6363

6464

6565
def validate_model(data: Dict[str, Any]) -> None:

pyproject.toml

-1
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,6 @@ filterwarnings = [
230230
"always:unclosed <socket.socket:ResourceWarning",
231231
"module:Jupyter is migrating its paths to use standard platformdirs:DeprecationWarning",
232232
"ignore:jupyter_server.base.zmqhandlers module is deprecated in Jupyter Server 2.0:DeprecationWarning",
233-
"ignore:zmq.eventloop.ioloop is deprecated in pyzmq 17:DeprecationWarning",
234233
]
235234

236235
[tool.coverage.report]

0 commit comments

Comments
 (0)