Rename `ROOT_CONTAINER` and `BASE_CONTAINER` to `ROOT_IMAGE` and `BASE_IMAGE` #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

mathbunnyru opened this issue Oct 9, 2024 · 0 comments · Fixed by #2155

Member

mathbunnyru commented Oct 9, 2024

These are not containers, but images.
In Docker, these 2 are different things, so we should use proper naming.

This change might be breaking for people, who build custom images, but it should only require a few lines change to fix it.

mathbunnyru mentioned this issue

Rename: ROOT_CONTAINER->ROOT_IMAGE, BASE_CONTAINER->BASE_IMAGE #2155

Merged

4 tasks

mathbunnyru closed this as completed in #2155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment