Revert "fix general.spec.ts lint problem as detected in CI run https://github.com/jupyter/notebook/actions/runs/5008582825/jobs/8976612053?pr=6866"

andrii-i · andrii-i · commit 2acb8339ba00 · 2023-05-17T18:15:34.000-07:00
This reverts commit 9f0b544.
diff --git a/ui-tests/test/general.spec.ts b/ui-tests/test/general.spec.ts
@@ -45,7 +45,7 @@ test.describe('General', () => {
 
     // special case for firefox headless issue
     // see https://github.com/jupyter/notebook/pull/6872#issuecomment-1549594166 for more details
-    if (browserName && browserName === 'firefox') {
+    if (browserName === 'firefox') {
       await hideAddCellButton(page);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ test.describe('General', () => {`
`45`	`45`
`46`	`46`	`// special case for firefox headless issue`
`47`	`47`	`// see https://github.com/jupyter/notebook/pull/6872#issuecomment-1549594166 for more details`
`48`		`- if (browserName && browserName === 'firefox') {`
	`48`	`+ if (browserName === 'firefox') {`
`49`	`49`	`await hideAddCellButton(page);`
`50`	`50`	`}`
`51`	`51`