Skip to content

Commit 59e03e2

Browse files
afshinafshin
committed
Update to Lumino 2
1 parent 4e830ec commit 59e03e2

File tree

20 files changed

+2206
-2126
lines changed

20 files changed

+2206
-2126
lines changed

‎app/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ async function main() {
147147
require('@jupyterlab/theme-dark-extension'),
148148
require('@jupyterlab/translation-extension'),
149149
// Add the "Hub Control Panel" menu option when running in JupyterHub
150-
require('@jupyterlab/user-extension'),
150+
require('@jupyterlab/collaboration-extension'),
151151
require('@jupyterlab/hub-extension')
152152
];
153153

‎app/package.json

+102-102
Original file line numberDiff line numberDiff line change
@@ -22,76 +22,76 @@
2222
"@jupyter-notebook/tree": "~7.0.0-alpha.5",
2323
"@jupyter-notebook/tree-extension": "~7.0.0-alpha.5",
2424
"@jupyter-notebook/ui-components": "~7.0.0-alpha.5",
25-
"@jupyterlab/application": "~4.0.0-alpha.10",
26-
"@jupyterlab/application-extension": "~4.0.0-alpha.10",
27-
"@jupyterlab/apputils": "~4.0.0-alpha.10",
28-
"@jupyterlab/apputils-extension": "~4.0.0-alpha.10",
29-
"@jupyterlab/cell-toolbar": "~4.0.0-alpha.10",
30-
"@jupyterlab/cell-toolbar-extension": "~4.0.0-alpha.10",
31-
"@jupyterlab/celltags": "~4.0.0-alpha.10",
32-
"@jupyterlab/codeeditor": "~4.0.0-alpha.10",
33-
"@jupyterlab/codemirror-extension": "~4.0.0-alpha.10",
34-
"@jupyterlab/completer": "~4.0.0-alpha.10",
35-
"@jupyterlab/completer-extension": "~4.0.0-alpha.10",
36-
"@jupyterlab/console": "~4.0.0-alpha.10",
37-
"@jupyterlab/console-extension": "~4.0.0-alpha.10",
25+
"@jupyterlab/application": "~4.0.0-alpha.13",
26+
"@jupyterlab/application-extension": "~4.0.0-alpha.13",
27+
"@jupyterlab/apputils": "~4.0.0-alpha.13",
28+
"@jupyterlab/apputils-extension": "~4.0.0-alpha.13",
29+
"@jupyterlab/cell-toolbar": "~4.0.0-alpha.13",
30+
"@jupyterlab/cell-toolbar-extension": "~4.0.0-alpha.13",
31+
"@jupyterlab/celltags": "~4.0.0-alpha.13",
32+
"@jupyterlab/codeeditor": "~4.0.0-alpha.13",
33+
"@jupyterlab/codemirror-extension": "~4.0.0-alpha.13",
34+
"@jupyterlab/collaboration": "~4.0.0-alpha.13",
35+
"@jupyterlab/collaboration-extension": "~4.0.0-alpha.13",
36+
"@jupyterlab/completer": "~4.0.0-alpha.13",
37+
"@jupyterlab/completer-extension": "~4.0.0-alpha.13",
38+
"@jupyterlab/console": "~4.0.0-alpha.13",
39+
"@jupyterlab/console-extension": "~4.0.0-alpha.13",
3840
"@jupyterlab/coreutils": "~6.0.0-alpha.10",
39-
"@jupyterlab/docmanager": "~4.0.0-alpha.10",
40-
"@jupyterlab/docmanager-extension": "~4.0.0-alpha.10",
41-
"@jupyterlab/docprovider": "~4.0.0-alpha.10",
42-
"@jupyterlab/docprovider-extension": "~4.0.0-alpha.10",
43-
"@jupyterlab/documentsearch": "~4.0.0-alpha.10",
44-
"@jupyterlab/documentsearch-extension": "~4.0.0-alpha.10",
45-
"@jupyterlab/filebrowser": "~4.0.0-alpha.10",
46-
"@jupyterlab/filebrowser-extension": "~4.0.0-alpha.10",
47-
"@jupyterlab/fileeditor": "~4.0.0-alpha.10",
48-
"@jupyterlab/fileeditor-extension": "~4.0.0-alpha.10",
49-
"@jupyterlab/hub-extension": "~4.0.0-alpha.10",
50-
"@jupyterlab/javascript-extension": "~4.0.0-alpha.10",
51-
"@jupyterlab/json-extension": "~4.0.0-alpha.10",
52-
"@jupyterlab/mainmenu": "~4.0.0-alpha.10",
53-
"@jupyterlab/mainmenu-extension": "~4.0.0-alpha.10",
54-
"@jupyterlab/markedparser-extension": "~4.0.0-alpha.10",
55-
"@jupyterlab/mathjax2-extension": "~4.0.0-alpha.10",
56-
"@jupyterlab/notebook": "~4.0.0-alpha.10",
57-
"@jupyterlab/notebook-extension": "~4.0.0-alpha.10",
41+
"@jupyterlab/docmanager": "~4.0.0-alpha.13",
42+
"@jupyterlab/docmanager-extension": "~4.0.0-alpha.13",
43+
"@jupyterlab/docprovider": "~4.0.0-alpha.13",
44+
"@jupyterlab/docprovider-extension": "~4.0.0-alpha.13",
45+
"@jupyterlab/documentsearch": "~4.0.0-alpha.13",
46+
"@jupyterlab/documentsearch-extension": "~4.0.0-alpha.13",
47+
"@jupyterlab/filebrowser": "~4.0.0-alpha.13",
48+
"@jupyterlab/filebrowser-extension": "~4.0.0-alpha.13",
49+
"@jupyterlab/fileeditor": "~4.0.0-alpha.13",
50+
"@jupyterlab/fileeditor-extension": "~4.0.0-alpha.13",
51+
"@jupyterlab/hub-extension": "~4.0.0-alpha.13",
52+
"@jupyterlab/javascript-extension": "~4.0.0-alpha.13",
53+
"@jupyterlab/json-extension": "~4.0.0-alpha.13",
54+
"@jupyterlab/mainmenu": "~4.0.0-alpha.13",
55+
"@jupyterlab/mainmenu-extension": "~4.0.0-alpha.13",
56+
"@jupyterlab/markedparser-extension": "~4.0.0-alpha.13",
57+
"@jupyterlab/mathjax2-extension": "~4.0.0-alpha.13",
58+
"@jupyterlab/notebook": "~4.0.0-alpha.13",
59+
"@jupyterlab/notebook-extension": "~4.0.0-alpha.13",
5860
"@jupyterlab/observables": "~5.0.0-alpha.10",
59-
"@jupyterlab/outputarea": "~4.0.0-alpha.10",
60-
"@jupyterlab/pdf-extension": "~4.0.0-alpha.10",
61-
"@jupyterlab/rendermime": "~4.0.0-alpha.10",
62-
"@jupyterlab/rendermime-extension": "~4.0.0-alpha.10",
63-
"@jupyterlab/rendermime-interfaces": "~3.8.0-alpha.10",
64-
"@jupyterlab/running-extension": "~4.0.0-alpha.10",
61+
"@jupyterlab/outputarea": "~4.0.0-alpha.13",
62+
"@jupyterlab/pdf-extension": "~4.0.0-alpha.13",
63+
"@jupyterlab/rendermime": "~4.0.0-alpha.13",
64+
"@jupyterlab/rendermime-extension": "~4.0.0-alpha.13",
65+
"@jupyterlab/rendermime-interfaces": "~3.8.0-alpha.13",
66+
"@jupyterlab/running-extension": "~4.0.0-alpha.13",
6567
"@jupyterlab/services": "~7.0.0-alpha.10",
66-
"@jupyterlab/settingregistry": "~4.0.0-alpha.10",
67-
"@jupyterlab/shared-models": "~4.0.0-alpha.10",
68-
"@jupyterlab/shortcuts-extension": "~4.0.0-alpha.10",
69-
"@jupyterlab/statedb": "~4.0.0-alpha.10",
70-
"@jupyterlab/statusbar": "~4.0.0-alpha.10",
71-
"@jupyterlab/terminal": "~4.0.0-alpha.10",
72-
"@jupyterlab/terminal-extension": "~4.0.0-alpha.10",
73-
"@jupyterlab/theme-dark-extension": "~4.0.0-alpha.10",
74-
"@jupyterlab/theme-light-extension": "~4.0.0-alpha.10",
75-
"@jupyterlab/tooltip": "~4.0.0-alpha.10",
76-
"@jupyterlab/tooltip-extension": "~4.0.0-alpha.10",
77-
"@jupyterlab/translation": "~4.0.0-alpha.10",
78-
"@jupyterlab/translation-extension": "~4.0.0-alpha.10",
79-
"@jupyterlab/ui-components": "~4.0.0-alpha.25",
80-
"@jupyterlab/user": "~4.0.0-alpha.10",
81-
"@jupyterlab/user-extension": "~4.0.0-alpha.10",
82-
"@jupyterlab/vega5-extension": "~4.0.0-alpha.10",
83-
"@lumino/algorithm": "~1.9.1",
84-
"@lumino/application": "~1.29.0",
85-
"@lumino/commands": "~1.20.0",
86-
"@lumino/coreutils": "~1.12.0",
87-
"@lumino/disposable": "~1.10.1",
88-
"@lumino/domutils": "~1.8.1",
89-
"@lumino/dragdrop": "~1.14.0",
90-
"@lumino/messaging": "~1.10.1",
91-
"@lumino/properties": "~1.8.1",
92-
"@lumino/signaling": "~1.10.1",
93-
"@lumino/virtualdom": "~1.14.1",
94-
"@lumino/widgets": "~1.32.0",
68+
"@jupyterlab/settingregistry": "~4.0.0-alpha.13",
69+
"@jupyterlab/shared-models": "~4.0.0-alpha.13",
70+
"@jupyterlab/shortcuts-extension": "~4.0.0-alpha.13",
71+
"@jupyterlab/statedb": "~4.0.0-alpha.13",
72+
"@jupyterlab/statusbar": "~4.0.0-alpha.13",
73+
"@jupyterlab/terminal": "~4.0.0-alpha.13",
74+
"@jupyterlab/terminal-extension": "~4.0.0-alpha.13",
75+
"@jupyterlab/theme-dark-extension": "~4.0.0-alpha.13",
76+
"@jupyterlab/theme-light-extension": "~4.0.0-alpha.13",
77+
"@jupyterlab/tooltip": "~4.0.0-alpha.13",
78+
"@jupyterlab/tooltip-extension": "~4.0.0-alpha.13",
79+
"@jupyterlab/translation": "~4.0.0-alpha.13",
80+
"@jupyterlab/translation-extension": "~4.0.0-alpha.13",
81+
"@jupyterlab/ui-components": "~4.0.0-alpha.28",
82+
"@jupyterlab/vega5-extension": "~4.0.0-alpha.13",
83+
"@lumino/algorithm": "^2.0.0-alpha.1",
84+
"@lumino/application": "^2.0.0-alpha.1",
85+
"@lumino/commands": "^2.0.0-alpha.1",
86+
"@lumino/coreutils": "^2.0.0-alpha.1",
87+
"@lumino/disposable": "^2.0.0-alpha.1",
88+
"@lumino/domutils": "^2.0.0-alpha.1",
89+
"@lumino/dragdrop": "^2.0.0-alpha.1",
90+
"@lumino/messaging": "^2.0.0-alpha.1",
91+
"@lumino/properties": "^2.0.0-alpha.1",
92+
"@lumino/signaling": "^2.0.0-alpha.1",
93+
"@lumino/virtualdom": "^2.0.0-alpha.1",
94+
"@lumino/widgets": "^2.0.0-alpha.1",
9595
"react": "~17.0.2",
9696
"react-dom": "~17.0.2",
9797
"yjs": "~13.5.38"
@@ -108,41 +108,41 @@
108108
"@jupyter-notebook/tree": "^7.0.0-alpha.5",
109109
"@jupyter-notebook/tree-extension": "^7.0.0-alpha.5",
110110
"@jupyter-notebook/ui-components": "^7.0.0-alpha.5",
111-
"@jupyterlab/application-extension": "^4.0.0-alpha.10",
112-
"@jupyterlab/apputils-extension": "^4.0.0-alpha.10",
113-
"@jupyterlab/cell-toolbar-extension": "^4.0.0-alpha.10",
114-
"@jupyterlab/celltags": "^4.0.0-alpha.10",
115-
"@jupyterlab/codemirror-extension": "^4.0.0-alpha.10",
116-
"@jupyterlab/completer-extension": "^4.0.0-alpha.10",
117-
"@jupyterlab/console-extension": "^4.0.0-alpha.10",
111+
"@jupyterlab/application-extension": "^4.0.0-alpha.13",
112+
"@jupyterlab/apputils-extension": "^4.0.0-alpha.13",
113+
"@jupyterlab/cell-toolbar-extension": "^4.0.0-alpha.13",
114+
"@jupyterlab/celltags": "^4.0.0-alpha.13",
115+
"@jupyterlab/collaboration-extension": "^4.0.0-alpha.13",
116+
"@jupyterlab/codemirror-extension": "^4.0.0-alpha.13",
117+
"@jupyterlab/completer-extension": "^4.0.0-alpha.13",
118+
"@jupyterlab/console-extension": "^4.0.0-alpha.13",
118119
"@jupyterlab/coreutils": "~6.0.0-alpha.10",
119-
"@jupyterlab/docmanager-extension": "^4.0.0-alpha.10",
120-
"@jupyterlab/docprovider-extension": "^4.0.0-alpha.10",
121-
"@jupyterlab/documentsearch-extension": "^4.0.0-alpha.10",
122-
"@jupyterlab/filebrowser-extension": "^4.0.0-alpha.10",
123-
"@jupyterlab/fileeditor-extension": "^4.0.0-alpha.10",
124-
"@jupyterlab/hub-extension": "^4.0.0-alpha.10",
125-
"@jupyterlab/javascript-extension": "^4.0.0-alpha.10",
126-
"@jupyterlab/json-extension": "^4.0.0-alpha.10",
127-
"@jupyterlab/mainmenu-extension": "^4.0.0-alpha.10",
128-
"@jupyterlab/markedparser-extension": "^4.0.0-alpha.10",
129-
"@jupyterlab/mathjax2-extension": "^4.0.0-alpha.10",
130-
"@jupyterlab/notebook-extension": "^4.0.0-alpha.10",
131-
"@jupyterlab/pdf-extension": "^4.0.0-alpha.10",
132-
"@jupyterlab/rendermime-extension": "^4.0.0-alpha.10",
133-
"@jupyterlab/running-extension": "^4.0.0-alpha.10",
134-
"@jupyterlab/shortcuts-extension": "^4.0.0-alpha.10",
135-
"@jupyterlab/terminal-extension": "^4.0.0-alpha.10",
136-
"@jupyterlab/theme-dark-extension": "^4.0.0-alpha.10",
137-
"@jupyterlab/theme-light-extension": "^4.0.0-alpha.10",
138-
"@jupyterlab/tooltip-extension": "^4.0.0-alpha.10",
139-
"@jupyterlab/translation-extension": "^4.0.0-alpha.10",
140-
"@jupyterlab/user-extension": "^4.0.0-alpha.10",
141-
"@jupyterlab/vega5-extension": "^4.0.0-alpha.10"
120+
"@jupyterlab/docmanager-extension": "^4.0.0-alpha.13",
121+
"@jupyterlab/docprovider-extension": "^4.0.0-alpha.13",
122+
"@jupyterlab/documentsearch-extension": "^4.0.0-alpha.13",
123+
"@jupyterlab/filebrowser-extension": "^4.0.0-alpha.13",
124+
"@jupyterlab/fileeditor-extension": "^4.0.0-alpha.13",
125+
"@jupyterlab/hub-extension": "^4.0.0-alpha.13",
126+
"@jupyterlab/javascript-extension": "^4.0.0-alpha.13",
127+
"@jupyterlab/json-extension": "^4.0.0-alpha.13",
128+
"@jupyterlab/mainmenu-extension": "^4.0.0-alpha.13",
129+
"@jupyterlab/markedparser-extension": "^4.0.0-alpha.13",
130+
"@jupyterlab/mathjax2-extension": "^4.0.0-alpha.13",
131+
"@jupyterlab/notebook-extension": "^4.0.0-alpha.13",
132+
"@jupyterlab/pdf-extension": "^4.0.0-alpha.13",
133+
"@jupyterlab/rendermime-extension": "^4.0.0-alpha.13",
134+
"@jupyterlab/running-extension": "^4.0.0-alpha.13",
135+
"@jupyterlab/shortcuts-extension": "^4.0.0-alpha.13",
136+
"@jupyterlab/terminal-extension": "^4.0.0-alpha.13",
137+
"@jupyterlab/theme-dark-extension": "^4.0.0-alpha.13",
138+
"@jupyterlab/theme-light-extension": "^4.0.0-alpha.13",
139+
"@jupyterlab/tooltip-extension": "^4.0.0-alpha.13",
140+
"@jupyterlab/translation-extension": "^4.0.0-alpha.13",
141+
"@jupyterlab/vega5-extension": "^4.0.0-alpha.13"
142142
},
143143
"devDependencies": {
144-
"@jupyterlab/builder": "^4.0.0-alpha.10",
145-
"@jupyterlab/buildutils": "^4.0.0-alpha.10",
144+
"@jupyterlab/builder": "^4.0.0-alpha.13",
145+
"@jupyterlab/buildutils": "^4.0.0-alpha.13",
146146
"@types/rimraf": "^3.0.0",
147147
"css-loader": "~5.0.1",
148148
"fs-extra": "^8.1.0",
@@ -163,6 +163,7 @@
163163
"name": "Jupyter Notebook",
164164
"extensions": [
165165
"@jupyter-notebook/application-extension",
166+
"@jupyterlab/collaboration-extension",
166167
"@jupyter-notebook/console-extension",
167168
"@jupyter-notebook/docmanager-extension",
168169
"@jupyter-notebook/documentsearch-extension",
@@ -192,8 +193,7 @@
192193
"@jupyterlab/theme-dark-extension",
193194
"@jupyterlab/theme-light-extension",
194195
"@jupyterlab/tooltip-extension",
195-
"@jupyterlab/translation-extension",
196-
"@jupyterlab/user-extension"
196+
"@jupyterlab/translation-extension"
197197
],
198198
"singletonPackages": [
199199
"@jupyter-notebook/tree",
@@ -202,6 +202,7 @@
202202
"@jupyterlab/cell-toolbar",
203203
"@jupyterlab/celltags",
204204
"@jupyterlab/codeeditor",
205+
"@jupyterlab/collaboration",
205206
"@jupyterlab/completer",
206207
"@jupyterlab/console",
207208
"@jupyterlab/coreutils",
@@ -224,7 +225,6 @@
224225
"@jupyterlab/terminal",
225226
"@jupyterlab/tooltip",
226227
"@jupyterlab/translation",
227-
"@jupyterlab/user",
228228
"@jupyterlab/ui-components",
229229
"@lumino/algorithm",
230230
"@lumino/application",

‎buildutils/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
"watch": "tsc -w --listEmittedFiles"
3131
},
3232
"dependencies": {
33-
"@jupyterlab/buildutils": "^4.0.0-alpha.10",
33+
"@jupyterlab/buildutils": "^4.0.0-alpha.13",
3434
"commander": "^6.2.0",
3535
"fs-extra": "^9.1.0",
3636
"typescript": "~4.6.3"

‎package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
"watch:lib": "lerna exec --stream --scope @jupyter-notebook/metapackage jlpm watch"
4343
},
4444
"devDependencies": {
45-
"@jupyterlab/buildutils": "^4.0.0-alpha.10",
45+
"@jupyterlab/buildutils": "^4.0.0-alpha.13",
4646
"@typescript-eslint/eslint-plugin": "^4.2.0",
4747
"@typescript-eslint/parser": "^4.2.0",
4848
"eslint": "^7.10.0",

‎packages/application-extension/package.json

+15-15
Original file line numberDiff line numberDiff line change
@@ -41,21 +41,21 @@
4141
"dependencies": {
4242
"@jupyter-notebook/application": "^7.0.0-alpha.5",
4343
"@jupyter-notebook/ui-components": "^7.0.0-alpha.5",
44-
"@jupyterlab/application": "^4.0.0-alpha.10",
45-
"@jupyterlab/apputils": "^4.0.0-alpha.10",
46-
"@jupyterlab/celltags": "^4.0.0-alpha.10",
47-
"@jupyterlab/codeeditor": "^4.0.0-alpha.10",
48-
"@jupyterlab/codemirror": "^4.0.0-alpha.10",
49-
"@jupyterlab/console": "^4.0.0-alpha.10",
50-
"@jupyterlab/coreutils": "^6.0.0-alpha.10",
51-
"@jupyterlab/docmanager": "^4.0.0-alpha.10",
52-
"@jupyterlab/docregistry": "^4.0.0-alpha.10",
53-
"@jupyterlab/mainmenu": "^4.0.0-alpha.10",
54-
"@jupyterlab/settingregistry": "^4.0.0-alpha.10",
55-
"@jupyterlab/translation": "^4.0.0-alpha.10",
56-
"@lumino/coreutils": "^1.12.0",
57-
"@lumino/disposable": "^1.10.1",
58-
"@lumino/widgets": "^1.32.0"
44+
"@jupyterlab/application": "^4.0.0-alpha.13",
45+
"@jupyterlab/apputils": "^4.0.0-alpha.13",
46+
"@jupyterlab/celltags": "^4.0.0-alpha.13",
47+
"@jupyterlab/codeeditor": "^4.0.0-alpha.13",
48+
"@jupyterlab/codemirror": "^4.0.0-alpha.13",
49+
"@jupyterlab/console": "^4.0.0-alpha.13",
50+
"@jupyterlab/coreutils": "^6.0.0-alpha.13",
51+
"@jupyterlab/docmanager": "^4.0.0-alpha.13",
52+
"@jupyterlab/docregistry": "^4.0.0-alpha.13",
53+
"@jupyterlab/mainmenu": "^4.0.0-alpha.13",
54+
"@jupyterlab/settingregistry": "^4.0.0-alpha.13",
55+
"@jupyterlab/translation": "^4.0.0-alpha.13",
56+
"@lumino/coreutils": "^2.0.0-alpha.1",
57+
"@lumino/disposable": "^2.0.0-alpha.1",
58+
"@lumino/widgets": "^2.0.0-alpha.1"
5959
},
6060
"devDependencies": {
6161
"rimraf": "~3.0.0",

‎packages/application-extension/src/index.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -442,7 +442,7 @@ const title: JupyterFrontEndPlugin<void> = {
442442
return;
443443
}
444444

445-
const result = await renameDialog(docManager, current.context.path);
445+
const result = await renameDialog(docManager, current.context);
446446

447447
// activate the current widget to bring the focus
448448
if (current) {
@@ -453,7 +453,7 @@ const title: JupyterFrontEndPlugin<void> = {
453453
return;
454454
}
455455

456-
const newPath = current.context.path ?? result.path;
456+
const newPath = current.context.path;
457457
const basename = PathExt.basename(newPath);
458458

459459
h.textContent = basename.replace(STRIP_IPYNB, '');

‎packages/application/package.json

+12-12
Original file line numberDiff line numberDiff line change
@@ -43,22 +43,22 @@
4343
"watch": "tsc -b --watch"
4444
},
4545
"dependencies": {
46-
"@jupyterlab/application": "^4.0.0-alpha.10",
47-
"@jupyterlab/coreutils": "^6.0.0-alpha.10",
48-
"@jupyterlab/docregistry": "^4.0.0-alpha.10",
49-
"@jupyterlab/rendermime-interfaces": "^3.8.0-alpha.10",
50-
"@jupyterlab/ui-components": "^4.0.0-alpha.25",
51-
"@lumino/algorithm": "^1.9.1",
52-
"@lumino/coreutils": "^1.12.0",
53-
"@lumino/messaging": "^1.10.1",
54-
"@lumino/polling": "^1.10.0",
55-
"@lumino/signaling": "^1.10.1",
56-
"@lumino/widgets": "^1.32.0"
46+
"@jupyterlab/application": "^4.0.0-alpha.13",
47+
"@jupyterlab/coreutils": "^6.0.0-alpha.13",
48+
"@jupyterlab/docregistry": "^4.0.0-alpha.13",
49+
"@jupyterlab/rendermime-interfaces": "^3.8.0-alpha.13",
50+
"@jupyterlab/ui-components": "^4.0.0-alpha.28",
51+
"@lumino/algorithm": "^2.0.0-alpha.1",
52+
"@lumino/coreutils": "^2.0.0-alpha.1",
53+
"@lumino/messaging": "^2.0.0-alpha.1",
54+
"@lumino/polling": "^2.0.0-alpha.1",
55+
"@lumino/signaling": "^2.0.0-alpha.1",
56+
"@lumino/widgets": "^2.0.0-alpha.1"
5757
},
5858
"devDependencies": {
5959
"@babel/core": "^7.11.6",
6060
"@babel/preset-env": "^7.12.1",
61-
"@jupyterlab/testutils": "^4.0.0-alpha.10",
61+
"@jupyterlab/testutils": "^4.0.0-alpha.13",
6262
"@types/jest": "^26.0.10",
6363
"jest": "^26.4.2",
6464
"rimraf": "~3.0.0",

‎packages/application/src/app.ts

+1-4
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,7 @@ export class NotebookApp extends JupyterFrontEnd<INotebookShell> {
2828
* @param options The instantiation options for an application.
2929
*/
3030
constructor(options: NotebookApp.IOptions = { shell: new NotebookShell() }) {
31-
super({
32-
...options,
33-
shell: options.shell ?? new NotebookShell()
34-
});
31+
super({ ...options, shell: options.shell ?? new NotebookShell() });
3532
if (options.mimeExtensions) {
3633
for (const plugin of createRendermimePlugins(options.mimeExtensions)) {
3734
this.registerPlugin(plugin);

0 commit comments

Comments
 (0)