Skip to content

Commit 936f647

Browse files
committed
set page_config in initalize_handlers
1 parent 1d02d06 commit 936f647

File tree

1 file changed

+14
-13
lines changed

1 file changed

+14
-13
lines changed

notebook/app.py

+14-13
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,6 @@ def get_page_config(self):
6262
api_token = os.getenv("JUPYTERHUB_API_TOKEN", "")
6363
page_config["token"] = api_token
6464

65-
nbclassic_enabled = self.server_extension_is_enabled("nbclassic")
66-
page_config["nbclassic_enabled"] = nbclassic_enabled
67-
6865
server_root = self.settings.get("server_root_dir", "")
6966
server_root = server_root.replace(os.sep, "/")
7067
server_root = os.path.normpath(os.path.expanduser(server_root))
@@ -116,16 +113,6 @@ def get_page_config(self):
116113
)
117114
return page_config
118115

119-
def server_extension_is_enabled(self, extension):
120-
"""Check if server extension is enabled."""
121-
try:
122-
extension_enabled = (
123-
self.extensionapp.serverapp.extension_manager.extensions[extension].enabled is True
124-
)
125-
except (AttributeError, KeyError, TypeError):
126-
extension_enabled = False
127-
return extension_enabled
128-
129116

130117
class RedirectHandler(NotebookBaseHandler):
131118
"""A redirect handler."""
@@ -274,8 +261,22 @@ def _default_user_settings_dir(self):
274261
def _default_workspaces_dir(self):
275262
return get_workspaces_dir()
276263

264+
def server_extension_is_enabled(self, extension):
265+
"""Check if server extension is enabled."""
266+
try:
267+
extension_enabled = (
268+
self.serverapp.extension_manager.extensions[extension].enabled is True
269+
)
270+
except (AttributeError, KeyError, TypeError):
271+
extension_enabled = False
272+
return extension_enabled
273+
277274
def initialize_handlers(self):
278275
"""Initialize handlers."""
276+
page_config = self.serverapp.web_app.settings.setdefault("page_config_data", {})
277+
nbclassic_enabled = self.server_extension_is_enabled("nbclassic")
278+
page_config["nbclassic_enabled"] = nbclassic_enabled
279+
279280
self.handlers.append(
280281
(
281282
rf"/{self.file_url_prefix}/((?!.*\.ipynb($|\?)).*)",

0 commit comments

Comments
 (0)