Enable nx (#6718)

jtpio · web-flow · commit b8e9cae07be8 · 2023-02-16T09:37:27.000+01:00
* Enable `nx`

* Remove the `install` script

* Remove `prepublishOnly`script

* try clean before build:prod

* debug

* more debug

* try removing pip install -e . step

* Remove debug
diff --git a/.github/workflows/check-release.yml b/.github/workflows/check-release.yml
@@ -21,9 +21,6 @@ jobs:
         uses: actions/checkout@v3
       - name: Base Setup
         uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
-      - name: Install Dependencies
-        run: |
-          pip install -e .
       - name: Check Release
         uses: jupyter-server/jupyter_releaser/.github/actions/check-release@v2
         with:
diff --git a/app/package.json b/app/package.json
@@ -7,7 +7,6 @@
     "build:prod": "webpack --mode=production",
     "clean": "rimraf build && jlpm run clean:static",
     "clean:static": "rimraf -g \"../notebook/static/!(favicons)\"",
-    "prepublishOnly": "yarn run build",
     "watch": "webpack --config ./webpack.config.watch.js"
   },
   "resolutions": {
diff --git a/buildutils/package.json b/buildutils/package.json
@@ -26,7 +26,6 @@
   "scripts": {
     "build": "tsc",
     "clean": "rimraf lib && rimraf tsconfig.tsbuildinfo",
-    "prepublishOnly": "npm run build",
     "watch": "tsc -w --listEmittedFiles"
   },
   "dependencies": {
diff --git a/lerna.json b/lerna.json
@@ -1,6 +1,5 @@
 {
   "npmClient": "yarn",
-  "useNx": false,
   "version": "independent",
   "useWorkspaces": true
 }
diff --git a/package.json b/package.json
@@ -29,7 +29,6 @@
     "eslint": "eslint . --ext .ts,.tsx --fix",
     "eslint:check": "eslint . --ext .ts,.tsx",
     "eslint:files": "eslint --fix",
-    "install": "lerna bootstrap",
     "integrity": "node buildutils/lib/ensure-repo.js",
     "prettier": "prettier --write \"**/*{.ts,.tsx,.js,.jsx,.css,.json,.md}\"",
     "prettier:check": "prettier --list-different \"**/*{.ts,.tsx,.js,.jsx,.css,.json,.md}\"",
diff --git a/packages/application-extension/package.json b/packages/application-extension/package.json
@@ -35,7 +35,6 @@
     "build:prod": "tsc -b",
     "clean": "rimraf lib && rimraf tsconfig.tsbuildinfo",
     "docs": "typedoc src",
-    "prepublishOnly": "npm run build",
     "watch": "tsc -b --watch"
   },
   "dependencies": {
diff --git a/packages/application/package.json b/packages/application/package.json
@@ -35,7 +35,6 @@
     "build:test": "tsc --build tsconfig.test.json",
     "clean": "rimraf lib && rimraf tsconfig.tsbuildinfo",
     "docs": "typedoc src",
-    "prepublishOnly": "npm run build",
     "test": "jest",
     "test:cov": "jest --collect-coverage",
     "test:debug": "node --inspect-brk node_modules/.bin/jest --runInBand",
diff --git a/packages/console-extension/package.json b/packages/console-extension/package.json
@@ -35,7 +35,6 @@
     "build:prod": "tsc -b",
     "clean": "rimraf lib && rimraf tsconfig.tsbuildinfo",
     "docs": "typedoc src",
-    "prepublishOnly": "npm run build",
     "watch": "tsc -b --watch"
   },
   "dependencies": {
diff --git a/packages/docmanager-extension/package.json b/packages/docmanager-extension/package.json
@@ -35,7 +35,6 @@
     "build:prod": "tsc -b",
     "clean": "rimraf lib && rimraf tsconfig.tsbuildinfo",
     "docs": "typedoc src",
-    "prepublishOnly": "npm run build",
     "watch": "tsc -b --watch"
   },
   "dependencies": {
diff --git a/packages/documentsearch-extension/package.json b/packages/documentsearch-extension/package.json
@@ -35,7 +35,6 @@
     "build:prod": "tsc -b",
     "clean": "rimraf lib && rimraf tsconfig.tsbuildinfo",
     "docs": "typedoc src",
-    "prepublishOnly": "npm run build",
     "watch": "tsc -b --watch"
   },
   "dependencies": {
diff --git a/packages/help-extension/package.json b/packages/help-extension/package.json
@@ -35,7 +35,6 @@
     "build:prod": "tsc -b",
     "clean": "rimraf lib && rimraf tsconfig.tsbuildinfo",
     "docs": "typedoc src",
-    "prepublishOnly": "npm run build",
     "watch": "tsc -b --watch"
   },
   "dependencies": {
diff --git a/packages/notebook-extension/package.json b/packages/notebook-extension/package.json
@@ -35,7 +35,6 @@
     "build:prod": "tsc -b",
     "clean": "rimraf lib && rimraf tsconfig.tsbuildinfo",
     "docs": "typedoc src",
-    "prepublishOnly": "npm run build",
     "watch": "tsc -b --watch"
   },
   "dependencies": {
diff --git a/packages/terminal-extension/package.json b/packages/terminal-extension/package.json
@@ -35,7 +35,6 @@
     "build:prod": "tsc -b",
     "clean": "rimraf lib && rimraf tsconfig.tsbuildinfo",
     "docs": "typedoc src",
-    "prepublishOnly": "npm run build",
     "watch": "tsc -b --watch"
   },
   "dependencies": {
diff --git a/packages/tree-extension/package.json b/packages/tree-extension/package.json
@@ -35,7 +35,6 @@
     "build:prod": "tsc -b",
     "clean": "rimraf lib && rimraf tsconfig.tsbuildinfo",
     "docs": "typedoc src",
-    "prepublishOnly": "npm run build",
     "watch": "tsc -b --watch"
   },
   "dependencies": {
diff --git a/packages/tree/package.json b/packages/tree/package.json
@@ -35,7 +35,6 @@
     "build:prod": "tsc -b",
     "clean": "rimraf lib && rimraf tsconfig.tsbuildinfo",
     "docs": "typedoc src",
-    "prepublishOnly": "npm run build",
     "watch": "tsc -b --watch"
   },
   "dependencies": {
diff --git a/packages/ui-components/package.json b/packages/ui-components/package.json
@@ -35,7 +35,6 @@
     "cleansvg": "svgo --config svgo.yaml",
     "docs": "typedoc src",
     "docs:init": "bash docs/build.sh",
-    "prepublishOnly": "npm run build",
     "test": "jest",
     "test:cov": "jest --collect-coverage",
     "test:debug": "node --inspect-brk node_modules/.bin/jest --runInBand",
diff --git a/pyproject.toml b/pyproject.toml
@@ -187,6 +187,7 @@ before-bump-version = [
     "python -m pip install hatch"
 ]
 before-build-npm = [
+    "jlpm clean",
     "jlpm build:prod"
 ]
 before-build-python = [

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,5 @@`
`1`	`1`	`{`
`2`	`2`	`"npmClient": "yarn",`
`3`		`- "useNx": false,`
`4`	`3`	`"version": "independent",`
`5`	`4`	`"useWorkspaces": true`
`6`	`5`	`}`
Original file line number	Diff line number	Diff line change
`@@ -187,6 +187,7 @@ before-bump-version = [`
`187`	`187`	`"python -m pip install hatch"`
`188`	`188`	`]`
`189`	`189`	`before-build-npm = [`
	`190`	`+ "jlpm clean",`
`190`	`191`	`"jlpm build:prod"`
`191`	`192`	`]`
`192`	`193`	`before-build-python = [`