Skip to content

Commit c353da4

Browse files
authored
Merge pull request #5968 from kevin-bates/skip-terminal-test-win-3.9
Skip terminal tests on Windows 3.9+ (temporary)
2 parents 5c081a3 + 434c5cb commit c353da4

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

.github/workflows/python.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
fail-fast: false
1212
matrix:
1313
os: [ubuntu, macos, windows]
14-
python-version: [ '3.6' , '3.7', '3.8', '3.9' ] # Windows 3.9 fails due to the pywinpty dependency not working
14+
python-version: [ '3.6' , '3.7', '3.8', '3.9' ] # Windows 3.9 fails due to the pywinpty dependency not working (Issue #5967)
1515
steps:
1616
- name: Checkout
1717
uses: actions/checkout@v1

notebook/conftest.py

+10
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
2+
import pytest
3+
4+
import sys
5+
6+
# TODO: Remove this hook once Issue #5967 is resolved.
7+
def pytest_ignore_collect(path):
8+
if str(path).endswith("test_terminals_api.py"):
9+
if sys.platform.startswith('win') and sys.version_info >= (3, 9):
10+
return True # do not collect

0 commit comments

Comments
 (0)