Skip to content

Commit cbf478b

Browse files
minrktakluyver
authored andcommitted
Merge pull request #3398 from minrk/tornado5
Get tests running with tornado 5
1 parent 3a2b442 commit cbf478b

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

.travis.yml

+1-7
Original file line numberDiff line numberDiff line change
@@ -35,19 +35,13 @@ before_install:
3535
if [[ $GROUP == js* ]]; then
3636
3737
fi
38-
- git clone --quiet --depth 1 https://github.com/minrk/travis-wheels travis-wheels
3938
- |
4039
if [[ $GROUP == docs ]]; then
4140
pip install -r docs/doc-requirements.txt
4241
fi
4342
4443
install:
45-
- pip install -f travis-wheels/wheelhouse file://$PWD#egg=notebook[test]
46-
- |
47-
if [[ "$TRAVIS_PYTHON_VERSION" == "2.7" ]]; then
48-
# Work around https://github.com/ipython/ipykernel/issues/288
49-
pip install ipykernel==4.6.1
50-
fi
44+
- pip install --pre .[test]
5145
- wget https://github.com/jgm/pandoc/releases/download/1.19.1/pandoc-1.19.1-1-amd64.deb && sudo dpkg -i pandoc-1.19.1-1-amd64.deb
5246

5347

notebook/services/kernels/tests/test_kernels_api.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,12 @@ def restart(self, id):
5353

5454
def websocket(self, id):
5555
loop = IOLoop()
56+
loop.make_current()
5657
req = HTTPRequest(
5758
url_path_join(self.base_url.replace('http', 'ws', 1), 'api/kernels', id, 'channels'),
5859
headers=self.headers,
5960
)
60-
f = websocket_connect(req, io_loop=loop)
61+
f = websocket_connect(req)
6162
return loop.run_sync(lambda : f)
6263

6364

notebook/tests/launchnotebook.py

+3
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,9 @@ def tmp(*parts):
135135

136136
started = Event()
137137
def start_thread():
138+
if 'asyncio' in sys.modules:
139+
import asyncio
140+
asyncio.set_event_loop(asyncio.new_event_loop())
138141
app = cls.notebook = NotebookApp(
139142
port=cls.port,
140143
port_retries=0,

0 commit comments

Comments
 (0)