Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accepting cookies is required but no useful warning is given #2337

Closed
Wrzlprmft opened this issue Mar 24, 2017 · 9 comments
Closed

Accepting cookies is required but no useful warning is given #2337

Wrzlprmft opened this issue Mar 24, 2017 · 9 comments

Comments

@Wrzlprmft
Copy link

I tried to open a Jupyter Notebook today and got the error message “Error loading notebook” without any further details. After some digging and guesswork, I found out that the problem was that I did not accept cookies from localhost. I suggest that the Notebook checks for this and sends a reasonable warning, if cookies are not accepted.

@gnestor
Copy link
Contributor

gnestor commented Mar 28, 2017

@Carreau Thoughts?

@Carreau
Copy link
Member

Carreau commented Apr 3, 2017

Hum, I'm not even sure how to check for this. I agree that we should try to have a better error message if we can detect it. Or at least having it in the FAQ.

@Carreau Carreau added this to the Backlog milestone Apr 3, 2017
@rosaswaby
Copy link
Contributor

Hi @ckilcrease and I were hoping to contribute this issue but we are not able to re-create it. We are both using the chrome browser and we have disabled the cookies in settings and we are both getting the same result which you can see below but it is not giving us the error that you received initially. Would you be able to give any more details on how to re-create the error message.

screen shot 2018-03-27 at 11 45 15 am

screen shot 2018-03-27 at 11 36 28 am

@takluyver
Copy link
Member

Educated guesswork here, but if you've got an existing notebook file, try running jupyter notebook my_notebook.ipynb to launch Jupyter and open the file.

@ckilcrease
Copy link
Contributor

Thanks, we were able to recreate it when running with an existing notebook file. We were thinking one approach might be checking if the user has cookies enabled, and if not, adding a warning message describing this. Does this sound like a good approach?

@takluyver
Copy link
Member

Yep, that sounds reasonable.

@rosaswaby
Copy link
Contributor

Thank you for your help! We (me and @ckilcrease) were working on the issue and we managed to detect if the cookies and enabled and produce the correct error message. Do you have any preference for how we should format the error message in the modal?

@takluyver
Copy link
Member

If you've got something that works, feel free to open a pull request - that's a good format for discussing the specific details, because we can point to particular bits of code.

@takluyver
Copy link
Member

Closed by #3511.

@takluyver takluyver modified the milestones: Backlog, 5.5 Apr 10, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants