-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accepting cookies is required but no useful warning is given #2337
Comments
@Carreau Thoughts? |
Hum, I'm not even sure how to check for this. I agree that we should try to have a better error message if we can detect it. Or at least having it in the FAQ. |
Hi @ckilcrease and I were hoping to contribute this issue but we are not able to re-create it. We are both using the chrome browser and we have disabled the cookies in settings and we are both getting the same result which you can see below but it is not giving us the error that you received initially. Would you be able to give any more details on how to re-create the error message. |
Educated guesswork here, but if you've got an existing notebook file, try running |
Thanks, we were able to recreate it when running with an existing notebook file. We were thinking one approach might be checking if the user has cookies enabled, and if not, adding a warning message describing this. Does this sound like a good approach? |
Yep, that sounds reasonable. |
Thank you for your help! We (me and @ckilcrease) were working on the issue and we managed to detect if the cookies and enabled and produce the correct error message. Do you have any preference for how we should format the error message in the modal? |
If you've got something that works, feel free to open a pull request - that's a good format for discussing the specific details, because we can point to particular bits of code. |
Closed by #3511. |
I tried to open a Jupyter Notebook today and got the error message “Error loading notebook” without any further details. After some digging and guesswork, I found out that the problem was that I did not accept cookies from
localhost
. I suggest that the Notebook checks for this and sends a reasonable warning, if cookies are not accepted.The text was updated successfully, but these errors were encountered: