Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding parameter to json.loads is deprecated and will be removed in Python 3.9 #5165

Closed
tirkarthi opened this issue Jan 18, 2020 · 1 comment · Fixed by #5174
Closed

Encoding parameter to json.loads is deprecated and will be removed in Python 3.9 #5165

tirkarthi opened this issue Jan 18, 2020 · 1 comment · Fixed by #5174

Comments

@tirkarthi
Copy link
Contributor

Some of the tests in test_gateway have encoding parameter passed to json.loads. This is ignored and deprecated to be removed in Python 3.9.

>>> json.loads(json.dumps({1: 1}), encoding='utf-8')
<stdin>:1: DeprecationWarning: 'encoding' is ignored and deprecated. It will be removed in Python 3.9
{'1': 1}

kspec_foo = json.loads(response.content.decode('utf-8'), encoding='utf-8')

@kevin-bates
Copy link
Member

Agreed. Did you want to provide a pull request for this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants