Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log kernel type #5424

Closed
pinarkavak opened this issue May 5, 2020 · 1 comment
Closed

Log kernel type #5424

pinarkavak opened this issue May 5, 2020 · 1 comment
Labels
status:resolved-locked

Comments

@pinarkavak
Copy link

pinarkavak commented May 5, 2020 •
edited
Loading

Kernel type information is only logged as a prometheus metric. It would be great to see it in the normal logs also.

I added this line: self.log.info("Kernel type: %s" % self._kernels[kernel_id].kernel_name)
at line 180 of "notebook/notebook/services/kernels/kernelmanager.py" and submitted PR: #5425.
@kevin-bates
Copy link
Member

Fixed via #5425

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status:resolved-locked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pinarkavak @kevin-bates