You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When the default language is set to an RTL (right-to-left) language (such as hebrew or arabic), the notebook UI is unusable.
Since translation is only partial, english text becomes garbled, and elements that should always be LTR (such as code blocks) are reversed, while others that maybe should be RTL (such as output blocks) are not.
To Reproduce
Go to Chrome's settings.
Go to "Languages".
Set "Hebrew" as the top priority.
Open a new jupyter notebook.
Expected behavior
Either properly support RTL language (a lot of work), or use LTR.
Screenshots
(Taken from this very old ipython issue)
Here's a screenshot - there's nothing useful in Hebrew here, but you get the period on the wrong end of the sentence, and the path is reversed.
Again, no useful information in Hebrew, the In [ ] bullets are on the wrong side, and you get RTL only when it's not helpful. If anything, I'd want the word שלום to be right-aligned, but nothing else.
Desktop (please complete the following information):
OS: Windows
Browser: Chrome
Version: 87
Additional context
There's a long standing ipython issue about this, ever since this was implemented. Most developers I know ran into this, found that issue, and used one of the workaround. This has always been a terrible default.
Note that the RTL layout is never correct. No user would use it intentionally because it solves no problems and creates several.
The solution is simple:
In notebook/static/bidi/bidi.js, the conditional setting of document.body.dir should be removed.
The text was updated successfully, but these errors were encountered:
@Gilthans I think you are using an old version of jupyter notebook. Since jupyter notebook version >= 6.1.0, notebook UI layout is not affected by browser language. For more information check out #5052 (comment).
Note that the tree view (i.e. the first screenshot in your post) is still affected by browser language, but the notebook itself (i.e. the second screenshot) doesn't care about browser language.
P.S. I've just done the repro steps on my notebook installation (version 6.1.5), and here's what I got:
P.S. 2
If anything, I'd want the word שלום to be right-aligned, but nothing else.
You can achieve this in version >= 6.1.0. In your LTR notebook, select the cell you want to right-align. Then open the command palette and select toogle current cell ltr/rtl direction.
I indeed seem to have 6.0.3 installed...
Thanks for the fix!
I'll send a message in the ipython thread (since this is where google brings you), may be a good idea to close the issue though.
Describe the bug
When the default language is set to an RTL (right-to-left) language (such as hebrew or arabic), the notebook UI is unusable.
Since translation is only partial, english text becomes garbled, and elements that should always be LTR (such as code blocks) are reversed, while others that maybe should be RTL (such as output blocks) are not.
To Reproduce
Expected behavior
Either properly support RTL language (a lot of work), or use LTR.
Screenshots

(Taken from this very old ipython issue)
Here's a screenshot - there's nothing useful in Hebrew here, but you get the period on the wrong end of the sentence, and the path is reversed.
Again, no useful information in Hebrew, the In [ ] bullets are on the wrong side, and you get RTL only when it's not helpful. If anything, I'd want the word שלום to be right-aligned, but nothing else.

Desktop (please complete the following information):
Additional context
There's a long standing ipython issue about this, ever since this was implemented. Most developers I know ran into this, found that issue, and used one of the workaround. This has always been a terrible default.
Note that the RTL layout is never correct. No user would use it intentionally because it solves no problems and creates several.
The solution is simple:
In notebook/static/bidi/bidi.js, the conditional setting of document.body.dir should be removed.
The text was updated successfully, but these errors were encountered: