Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the RTC user menu dropdown in the top area #6555

Closed
jtpio opened this issue Oct 6, 2022 · 2 comments · Fixed by #6565
Closed

Align the RTC user menu dropdown in the top area #6555

jtpio opened this issue Oct 6, 2022 · 2 comments · Fixed by #6565

Comments

@jtpio
Copy link
Member

jtpio commented Oct 6, 2022

A user menu dropdown is automatically added to the top area of the notebook when RTC is enabled:

image

This menu is currently a bit off and should be aligned vertically so it's more visually pleasing.

@jtpio jtpio added this to the 7.0 milestone Oct 6, 2022
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label Oct 6, 2022
@jtpio
Copy link
Member Author

jtpio commented Oct 6, 2022

Adding some pointers if anyone wants to have a look and open a PR.

The Notebook application should be started in collaborative mode with jupyter notebook --collaborative.

Then probably some CSS could be applied to that component, similar to the kernel logo also in the top area:

.jp-NotebookKernelLogo {
flex: 0 0 auto;
display: flex;
align-items: center;
text-align: center;
margin-right: 8px;
}

@jtpio jtpio added enhancement help wanted good first issue and removed status:Needs Triage Applied to issues that need triage labels Oct 6, 2022
@jtpio jtpio changed the title Align the user menu dropdown in the top area Align the RTC user menu dropdown in the top area Oct 6, 2022
@stephenisau
Copy link

I can take a look at this ticket over the weekend if no one's claimed it yet.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants