Skip to content

Commit 0e184cf

Browse files
committed
Improve documention in publish.yml, fix docker image tag names
1 parent 37c79c1 commit 0e184cf

File tree

1 file changed

+14
-1
lines changed

1 file changed

+14
-1
lines changed

.github/workflows/publish.yml

+14-1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,11 @@ jobs:
2828
steps:
2929
- uses: actions/checkout@v2
3030

31+
# Setup docker to build for multiple platforms (requires qemu).
32+
# See:
33+
# https://github.com/docker/build-push-action/tree/v2.3.0#usage
34+
# https://github.com/docker/build-push-action/blob/v2.3.0/docs/advanced/multi-platform.md
35+
3136
- name: Set up QEMU
3237
uses: docker/setup-qemu-action@v1
3338

@@ -43,13 +48,19 @@ jobs:
4348
password: ${{ secrets.DOCKERHUB_TOKEN }}
4449

4550
# https://github.com/manics/action-major-minor-tag-calculator-test
51+
# If this is a tagged build this will return additional parent tags.
52+
# E.g. 1.2.3 is expanded to Docker tags
53+
# [{prefix}:1.2.3, {prefix}:1.2, {prefix}:1, {prefix}:latest] unless
54+
# this is a backported tag in which case the newer tags aren't updated.
55+
# For branches this will return the branch name.
56+
# If GITHUB_TOKEN isn't available (e.g. in PRs) returns no tags [].
4657
- name: Get list of tags
4758
id: gettags
4859
# TODO: Move to org?
4960
uses: manics/action-major-minor-tag-calculator@main
5061
with:
5162
githubToken: ${{ secrets.GITHUB_TOKEN }}
52-
prefix: "manics/action-major-minor-tag-calculator-test:"
63+
prefix: "jupyterhub/configurable-http-proxy:"
5364

5465
- name: Display tags
5566
run: echo "Docker tags ${{ steps.gettags.outputs.tags }}"
@@ -59,4 +70,6 @@ jobs:
5970
with:
6071
platforms: linux/amd64,linux/arm64
6172
push: ${{ startsWith(github.ref, 'refs/tags/') }}
73+
# tags parameter must be a string input so convert `gettags` JSON
74+
# array into a comma separated list of tags
6275
tags: ${{ join(fromJson(steps.gettags.outputs.tags)) }}

0 commit comments

Comments
 (0)