Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm engine requirement isn't taken into account at install time #348

Closed
minrk opened this issue Sep 17, 2021 · 0 comments · Fixed by #349
Closed

npm engine requirement isn't taken into account at install time #348

minrk opened this issue Sep 17, 2021 · 0 comments · Fixed by #349
Labels

Comments

@minrk
Copy link
Member

minrk commented Sep 17, 2021

In #323, we bumped the minimum node version, in part because I had assumed npm's node engine resolution worked like pip's (find the latest version we can run), but it doesn't. Instead, it just warns that it won't work. It appears the best we can hope for is turning that warning into an error by adding strict engine checks, it cannot be considered an input to the installation request (which seems wild to me!).

Since the latest Ubuntu LTS (20.04) is still on node 10, I think we should bump minimum node back down to 10, which means dropping commander back to 7.x.

At the very least, in the future we should consider bumping the engine a major revision (which @consideRatio originally proposed, but I recommended against due to this misunderstanding), to make it easier to communicate the boundaries.

@minrk minrk changed the title npm engine requirement isn't taken into account npm engine requirement isn't taken into account at install time Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants