Skip to content

Commit 1964ec0

Browse files
committed
Fix #13: Xcode project: Remove IOSurface from iOS/tvOS builds.
1 parent 4cda8f7 commit 1964ec0

File tree

3 files changed

+19
-8
lines changed

3 files changed

+19
-8
lines changed

Diff for: ios/xcode/OpenGLES.xcodeproj/project.pbxproj

+4-6
Original file line numberDiff line numberDiff line change
@@ -860,8 +860,6 @@
860860
0A90FA2B2406831B005BA9A8 /* OpenGL.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 0A90FA2A2406831B005BA9A8 /* OpenGL.framework */; settings = {ATTRIBUTES = (Weak, ); }; };
861861
0A90FA2C240683CD005BA9A8 /* IOSurface.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 0A9A6BE423916BFB006A152A /* IOSurface.framework */; };
862862
0A90FA2D2406840B005BA9A8 /* OpenGLES.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 0AA2014C23474A9000E0B98C /* OpenGLES.framework */; platformFilter = ios; settings = {ATTRIBUTES = (Weak, ); }; };
863-
0A90FA2E24068422005BA9A8 /* IOSurface.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 0A9A6BE423916BFB006A152A /* IOSurface.framework */; settings = {ATTRIBUTES = (Weak, ); }; };
864-
0A90FA2F24068466005BA9A8 /* IOSurface.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 0A9A6BE423916BFB006A152A /* IOSurface.framework */; settings = {ATTRIBUTES = (Weak, ); }; };
865863
0A90FA3024068473005BA9A8 /* OpenGLES.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 0AA2014C23474A9000E0B98C /* OpenGLES.framework */; platformFilter = ios; settings = {ATTRIBUTES = (Weak, ); }; };
866864
0A90FB422406D025005BA9A8 /* OpenGL.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 0A90FA2A2406831B005BA9A8 /* OpenGL.framework */; settings = {ATTRIBUTES = (Weak, ); }; };
867865
0A90FB452406D141005BA9A8 /* samples_env_setup.mm in Sources */ = {isa = PBXBuildFile; fileRef = 0A97E48C23485F69007CA616 /* samples_env_setup.mm */; };
@@ -2730,7 +2728,6 @@
27302728
0AF9598F244C7CD700F59740 /* CoreFoundation.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 0AC2A5212346714A0045B949 /* CoreFoundation.framework */; };
27312729
0AF95990244C7CD700F59740 /* UIKit.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 0AA2015023474D9700E0B98C /* UIKit.framework */; };
27322730
0AF95991244C7CD700F59740 /* CoreGraphics.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 0A9A6BA8239126DB006A152A /* CoreGraphics.framework */; };
2733-
0AF95992244C7CD700F59740 /* IOSurface.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 0A9A6BE423916BFB006A152A /* IOSurface.framework */; settings = {ATTRIBUTES = (Weak, ); }; };
27342731
0AF95993244C7CD700F59740 /* OpenGLES.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 0AA2014C23474A9000E0B98C /* OpenGLES.framework */; settings = {ATTRIBUTES = (Weak, ); }; };
27352732
0AF959A5244C7D5800F59740 /* SampleApplication.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 0AA200E82347428200E0B98C /* SampleApplication.cpp */; };
27362733
0AF959A6244C7D5800F59740 /* samples_env_setup.mm in Sources */ = {isa = PBXBuildFile; fileRef = 0A97E48C23485F69007CA616 /* samples_env_setup.mm */; };
@@ -5097,7 +5094,6 @@
50975094
0AC2A5232346714A0045B949 /* CoreFoundation.framework in Frameworks */,
50985095
0AAF41102354CE9B000E3CC8 /* UIKit.framework in Frameworks */,
50995096
0A9A6BA9239126DB006A152A /* CoreGraphics.framework in Frameworks */,
5100-
0A90FA2E24068422005BA9A8 /* IOSurface.framework in Frameworks */,
51015097
0A90FA2D2406840B005BA9A8 /* OpenGLES.framework in Frameworks */,
51025098
);
51035099
runOnlyForDeploymentPostprocessing = 0;
@@ -5510,7 +5506,6 @@
55105506
0AA2FFAE2347273200E0B98C /* QuartzCore.framework in Frameworks */,
55115507
0AAF41112354CEA7000E3CC8 /* UIKit.framework in Frameworks */,
55125508
0A9A6BAA239126ED006A152A /* CoreGraphics.framework in Frameworks */,
5513-
0A90FA2F24068466005BA9A8 /* IOSurface.framework in Frameworks */,
55145509
0A90FA3024068473005BA9A8 /* OpenGLES.framework in Frameworks */,
55155510
);
55165511
runOnlyForDeploymentPostprocessing = 0;
@@ -5599,7 +5594,6 @@
55995594
0AF9598F244C7CD700F59740 /* CoreFoundation.framework in Frameworks */,
56005595
0AF95990244C7CD700F59740 /* UIKit.framework in Frameworks */,
56015596
0AF95991244C7CD700F59740 /* CoreGraphics.framework in Frameworks */,
5602-
0AF95992244C7CD700F59740 /* IOSurface.framework in Frameworks */,
56035597
0AF95993244C7CD700F59740 /* OpenGLES.framework in Frameworks */,
56045598
);
56055599
runOnlyForDeploymentPostprocessing = 0;
@@ -14748,6 +14742,7 @@
1474814742
CLANG_ENABLE_OBJC_ARC = NO;
1474914743
CODE_SIGN_STYLE = Automatic;
1475014744
GCC_PREPROCESSOR_DEFINITIONS = (
14745+
ANGLE_DISABLE_IOSURFACE,
1475114746
ANGLE_ENABLE_OPENGL_NULL,
1475214747
"${inherited}",
1475314748
);
@@ -14765,6 +14760,7 @@
1476514760
CLANG_ENABLE_OBJC_ARC = NO;
1476614761
CODE_SIGN_STYLE = Automatic;
1476714762
GCC_PREPROCESSOR_DEFINITIONS = (
14763+
ANGLE_DISABLE_IOSURFACE,
1476814764
ANGLE_ENABLE_OPENGL_NULL,
1476914765
"${inherited}",
1477014766
);
@@ -15319,6 +15315,7 @@
1531915315
CLANG_ENABLE_OBJC_ARC = NO;
1532015316
CODE_SIGN_STYLE = Automatic;
1532115317
GCC_PREPROCESSOR_DEFINITIONS = (
15318+
ANGLE_DISABLE_IOSURFACE,
1532215319
ANGLE_ENABLE_OPENGL_NULL,
1532315320
"${inherited}",
1532415321
);
@@ -15337,6 +15334,7 @@
1533715334
CLANG_ENABLE_OBJC_ARC = NO;
1533815335
CODE_SIGN_STYLE = Automatic;
1533915336
GCC_PREPROCESSOR_DEFINITIONS = (
15337+
ANGLE_DISABLE_IOSURFACE,
1534015338
ANGLE_ENABLE_OPENGL_NULL,
1534115339
"${inherited}",
1534215340
);

Diff for: src/libANGLE/renderer/gl/eagl/DisplayEAGL.mm

+13-1
Original file line numberDiff line numberDiff line change
@@ -156,8 +156,12 @@
156156
EGLClientBuffer clientBuffer,
157157
const egl::AttributeMap &attribs)
158158
{
159+
#if defined(ANGLE_DISABLE_IOSURFACE)
160+
return nullptr;
161+
#else
159162
ASSERT(buftype == EGL_IOSURFACE_ANGLE);
160163
return new IOSurfaceSurfaceEAGL(state, mContext, clientBuffer, attribs);
164+
#endif
161165
}
162166

163167
SurfaceImpl *DisplayEAGL::createPixmapSurface(const egl::SurfaceState &state,
@@ -272,13 +276,17 @@
272276
const egl::AttributeMap &attribs) const
273277
{
274278
ASSERT(buftype == EGL_IOSURFACE_ANGLE);
279+
#if defined(ANGLE_DISABLE_IOSURFACE)
280+
return egl::EglBadAttribute();
275281

282+
#else
276283
if (!IOSurfaceSurfaceEAGL::validateAttributes(clientBuffer, attribs))
277284
{
278285
return egl::EglBadAttribute();
279286
}
280287

281288
return egl::NoError();
289+
#endif // ANGLE_DISABLE_IOSURFACE
282290
}
283291

284292
std::string DisplayEAGL::getVendorString() const
@@ -295,9 +303,13 @@
295303
void DisplayEAGL::generateExtensions(egl::DisplayExtensions *outExtensions) const
296304
{
297305
outExtensions->flexibleSurfaceCompatibility = true;
298-
outExtensions->iosurfaceClientBuffer = true;
299306
outExtensions->surfacelessContext = true;
300307
outExtensions->deviceQuery = true;
308+
# if defined(ANGLE_DISABLE_IOSURFACE)
309+
outExtensions->iosurfaceClientBuffer = false;
310+
# else
311+
outExtensions->iosurfaceClientBuffer = true;
312+
# endif
301313

302314
// Contexts are virtualized so textures can be shared globally
303315
outExtensions->displayTextureShareGroup = true;

Diff for: src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.mm

+2-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@
2525

2626
#import "common/platform.h"
2727

28-
#if defined(ANGLE_PLATFORM_IOS) && !defined(ANGLE_PLATFORM_MACCATALYST)
28+
#if defined(ANGLE_PLATFORM_IOS) && !defined(ANGLE_PLATFORM_MACCATALYST) && \
29+
!defined(ANGLE_DISABLE_IOSURFACE)
2930

3031
# import "libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.h"
3132

0 commit comments

Comments
 (0)