Skip to content

Commit a9ceec4

Browse files
committedOct 7, 2018
Remove remaining glyphs and fix selectize overflow
1 parent ca276f0 commit a9ceec4

File tree

9 files changed

+18
-12
lines changed

9 files changed

+18
-12
lines changed
 

Diff for: ‎static/panes/cfg-view.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,8 @@ function Cfg(hub, container, state) {
106106
sortField: 'name',
107107
valueField: 'name',
108108
labelField: 'name',
109-
searchField: ['name']
109+
searchField: ['name'],
110+
dropdownParent: 'body'
110111
}).on('change', _.bind(function (e) {
111112
var selectedFn = this.functions[e.target.value];
112113
if (selectedFn) {

Diff for: ‎static/panes/compiler.js

+4-3
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,8 @@ function Compiler(hub, container, state) {
127127
optgroups: this.getGroupsInUse(),
128128
lockOptgroupOrder: true,
129129
options: _.map(this.getCurrentLangCompilers(), _.identity),
130-
items: this.compiler ? [this.compiler.id] : []
130+
items: this.compiler ? [this.compiler.id] : [],
131+
dropdownParent: 'body'
131132
}).on('change', _.bind(function (e) {
132133
var val = $(e.target).val();
133134
if (val) {
@@ -1330,7 +1331,7 @@ Compiler.prototype.onAsmToolTip = function (ed) {
13301331
function appendInfo(url) {
13311332
return '<br><br>For more information, visit <a href="' + url +
13321333
'" target="_blank" rel="noopener noreferrer">the ' + opcode +
1333-
' documentation <sup><small class="glyphicon glyphicon-new-window opens-new-window"' +
1334+
' documentation <sup><small class="fas fa-external-link-alt opens-new-window"' +
13341335
' title="Opens in a new window"></small></sup></a>.';
13351336
}
13361337

@@ -1428,7 +1429,7 @@ Compiler.prototype.updateLibsDropdown = function () {
14281429
.prop('target', '_blank')
14291430
.prop('rel', 'noopener noreferrer')
14301431
.append($('<sup></sup>')
1431-
.addClass('glyphicon glyphicon-new-window')
1432+
.addClass('fas fa-external-link-alt ')
14321433
)
14331434
);
14341435
}

Diff for: ‎static/panes/conformance-view.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ Conformance.prototype.updateLibsDropdown = function () {
182182
.prop('target', '_blank')
183183
.prop('rel', 'noopener noreferrer')
184184
.append($('<sup></sup>')
185-
.addClass('glyphicon glyphicon-new-window')
185+
.addClass('fas fa-external-link-alt ')
186186
)
187187
);
188188
}
@@ -364,7 +364,8 @@ Conformance.prototype.addCompilerSelector = function (config) {
364364
optgroupField: 'group',
365365
optgroups: this.getGroupsInUse(),
366366
options: _.filter(options.compilers, isVisible),
367-
items: config.compilerId ? [config.compilerId] : []
367+
items: config.compilerId ? [config.compilerId] : [],
368+
dropdownParent: 'body'
368369
})
369370
.on('change', _.bind(function (e) {
370371
onCompilerChange($(e.target).val());

Diff for: ‎static/panes/diff.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,8 @@ function Diff(hub, container, state) {
8585
'<li class="compilerId">Compiler #' + escape(item.id) + '</li>' +
8686
'</ul></div>';
8787
}
88-
}
88+
},
89+
dropdownParent: 'body'
8990
}).on('change', _.bind(function (e) {
9091
var target = $(e.target);
9192
var compiler = this.compilers[target.val()];

Diff for: ‎static/panes/editor.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,8 @@ function Editor(hub, state, container) {
128128
labelField: 'name',
129129
searchField: ['name'],
130130
options: _.map(usableLanguages, _.identity),
131-
items: [this.currentLanguage.id]
131+
items: [this.currentLanguage.id],
132+
dropdownParent: 'body'
132133
}).on('change', _.bind(function (e) {
133134
this.onLanguageChange($(e.target).val());
134135
}, this));

Diff for: ‎static/panes/gccdump-view.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,8 @@ function GccDump(hub, container, state) {
5353
minimap: {
5454
maxColumn: 80
5555
},
56-
lineNumbersMinChars: 3
56+
lineNumbersMinChars: 3,
57+
dropdownParent: 'body'
5758
});
5859

5960
this.initButtons(state);

Diff for: ‎views/embed.pug

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ html(lang="en")
77
body.embedded
88
a.float-link.link(href="/" target="_blank")
99
| Edit on #{language} Compiler Explorer
10-
span.glyphicon.glyphicon-new-window
10+
span.fas.fa-external-link-alt
1111
br
1212

1313
#root

Diff for: ‎views/index.pug

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ html(lang="en")
3333
button.close(type="button" aria-hidden="true") &times;
3434
ul.navbar-nav.navbar-right
3535
li.nav-item
36-
a.nav-link#share(href="javascript:;") Share#[b.caret]
36+
a.nav-link#share(href="javascript:;") Share
3737
li.nav-item.dropdown
3838
a.nav-link.dropdown-toggle#otherDropdown(href="javascript:;" role="button" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false") Other#[b.caret]
3939
div.dropdown-menu.dropdown-menu-right(aria-labelledby="otherDropdown")

Diff for: ‎views/popups.pug

+1-1
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@
8080
label
8181
| Default language&nbsp;
8282
small
83-
span.glyphicon.glyphicon-info-sign(title="New editors only (Reset UI to clear yours)" aria-label="New editors only (Reset UI to clear yours)")
83+
span.fas.fa-info-circle(title="New editors only (Reset UI to clear yours)" aria-label="New editors only (Reset UI to clear yours)")
8484
select.defaultLanguage
8585
div
8686
label

0 commit comments

Comments
 (0)