Skip to content

Commit edf170d

Browse files
huynq0911stuartnelson3
authored andcommitted
Add signed off to commit (prometheus#1766)
- Fix error string should not be capitalized from [Golang coding convention](https://github.com/golang/go/wiki/CodeReviewComments#error-strings) - Fix some typos Signed-off-by: Nguyen Quang Huy <[email protected]>
1 parent 57c4ff1 commit edf170d

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

CHANGELOG.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ deprecated. API v1 will be removed with Alertmanager release v0.18.0.
2626
* [FEATURE] Add support for images and links in the PagerDuty notification config (#1559)
2727
* [FEATURE] Add support for grouping by all labels (#1588)
2828
* [FEATURE] [amtool] Add timeout support to amtool commands (#1471)
29-
* [FEATURE] [amtool] Added `config routes` tools for vizualization and testing routes (#1511)
29+
* [FEATURE] [amtool] Added `config routes` tools for visualization and testing routes (#1511)
3030
* [FEATURE] [amtool] Support adding alerts using amtool (#1461)
3131
* [ENHANCEMENT] Add support for --log.format (#1658)
3232
* [ENHANCEMENT] Add CORS support to API v2 (#1667)

api/v1/api_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ func newFakeAlerts(alerts []*types.Alert, withErr bool) *fakeAlerts {
5151
fps: fps,
5252
}
5353
if withErr {
54-
f.err = errors.New("Error occured")
54+
f.err = errors.New("error occurred")
5555
}
5656
return f
5757
}

cli/test_routing_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ func checkResolvedReceivers(mainRoute *dispatch.Route, ls client.LabelSet, expec
3636
return err
3737
}
3838
if !reflect.DeepEqual(expectedReceivers, resolvedReceivers) {
39-
return fmt.Errorf("Unexpected routing result want: `%s`, got: `%s`", strings.Join(expectedReceivers, ","), strings.Join(resolvedReceivers, ","))
39+
return fmt.Errorf("unexpected routing result want: `%s`, got: `%s`", strings.Join(expectedReceivers, ","), strings.Join(resolvedReceivers, ","))
4040
}
4141
return nil
4242
}

ui/app/CONTRIBUTING.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ Your app should be available at `http://localhost:<port>`. Navigate to
6161
`src/Main.elm`. Any changes to the file system are detected automatically,
6262
triggering a recompile of the project.
6363

64-
## Commiting changes
64+
## Committing changes
6565

6666
Before you commit changes, please run `make build-all` on the root level
6767
Makefile. Please include `asset/*_vfsdata.go` in your commit.

0 commit comments

Comments
 (0)