Skip to content

Commit 22dfa2b

Browse files
committedDec 22, 2018
Rollup merge of rust-lang#56970 - Firstyear:mem_uninit_doc_ptr_drop, r=Manishearth
Mem uninit doc ptr drop Extend the mem::uninitialized documentation to account for partially initialized arrays and how to correctly handle these. These are used in some datastructures (trees for example) or in FFI. r? @Manishearth

File tree

1 file changed

+39
-0
lines changed

1 file changed

+39
-0
lines changed
 

‎src/libcore/mem.rs

+39
Original file line numberDiff line numberDiff line change
@@ -530,6 +530,12 @@ pub unsafe fn zeroed<T>() -> T {
530530
/// it goes out of scope (and therefore would be dropped). Note that this
531531
/// includes a `panic` occurring and unwinding the stack suddenly.
532532
///
533+
/// If you partially initialize an array, you may need to use
534+
/// [`ptr::drop_in_place`][drop_in_place] to remove the elements you have fully
535+
/// initialized followed by [`mem::forget`][mem_forget] to prevent drop running
536+
/// on the array. If a partially allocated array is dropped this will lead to
537+
/// undefined behaviour.
538+
///
533539
/// # Examples
534540
///
535541
/// Here's how to safely initialize an array of [`Vec`]s.
@@ -583,11 +589,44 @@ pub unsafe fn zeroed<T>() -> T {
583589
/// println!("{:?}", &data[0]);
584590
/// ```
585591
///
592+
/// This example shows how to handle partially initialized arrays, which could
593+
/// be found in low-level datastructures.
594+
///
595+
/// ```
596+
/// use std::mem;
597+
/// use std::ptr;
598+
///
599+
/// // Count the number of elements we have assigned.
600+
/// let mut data_len: usize = 0;
601+
/// let mut data: [String; 1000];
602+
///
603+
/// unsafe {
604+
/// data = mem::uninitialized();
605+
///
606+
/// for elem in &mut data[0..500] {
607+
/// ptr::write(elem, String::from("hello"));
608+
/// data_len += 1;
609+
/// }
610+
///
611+
/// // For each item in the array, drop if we allocated it.
612+
/// for i in &mut data[0..data_len] {
613+
/// ptr::drop_in_place(i);
614+
/// }
615+
/// }
616+
/// // Forget the data. If this is allowed to drop, you may see a crash such as:
617+
/// // 'mem_uninit_test(2457,0x7fffb55dd380) malloc: *** error for object
618+
/// // 0x7ff3b8402920: pointer being freed was not allocated'
619+
/// mem::forget(data);
620+
/// ```
621+
///
586622
/// [`Vec`]: ../../std/vec/struct.Vec.html
587623
/// [`vec!`]: ../../std/macro.vec.html
588624
/// [`Clone`]: ../../std/clone/trait.Clone.html
589625
/// [ub]: ../../reference/behavior-considered-undefined.html
590626
/// [write]: ../ptr/fn.write.html
627+
/// [drop_in_place]: ../ptr/fn.drop_in_place.html
628+
/// [mem_zeroed]: fn.zeroed.html
629+
/// [mem_forget]: fn.forget.html
591630
/// [copy]: ../intrinsics/fn.copy.html
592631
/// [copy_no]: ../intrinsics/fn.copy_nonoverlapping.html
593632
/// [`Drop`]: ../ops/trait.Drop.html

0 commit comments

Comments
 (0)
Please sign in to comment.