fix: PR updates

Author: DanielRivers

lib/utils/generateAuthUrl.test.ts

@@ -30,7 +30,7 @@ describe("generateAuthUrl", () => {
     expect(nonce!.length).toBe(16);
     result.url.searchParams.delete("nonce");
     const codeChallenge = result.url.searchParams.get("code_challenge");
-    expect(codeChallenge!.length).toBeGreaterThan(32);
+    expect(codeChallenge!.length).toBeGreaterThan(43);
     result.url.searchParams.delete("code_challenge");
     expect(result.url.toString()).toBe(expectedUrl);
   });
@@ -86,7 +86,7 @@ describe("generateAuthUrl", () => {
     result.url.searchParams.delete("nonce");
 
     const codeChallenge = result.url.searchParams.get("code_challenge");
-    expect(codeChallenge!.length).toBeGreaterThan(32);
+    expect(codeChallenge!.length).toBeGreaterThan(43);
     result.url.searchParams.delete("code_challenge");
 
     expect(result.url.toString()).toBe(expectedUrl);
@@ -115,7 +115,7 @@ describe("generateAuthUrl", () => {
     expect(state).not.toBeNull();
     expect(state!.length).toBe(32);
     const codeChallenge = result.url.searchParams.get("code_challenge");
-    expect(codeChallenge!.length).toBeGreaterThan(32);
+    expect(codeChallenge!.length).toBeGreaterThan(43);
     result.url.searchParams.delete("code_challenge");
     result.url.searchParams.delete("nonce");
     result.url.searchParams.delete("state");

lib/utils/generateAuthUrl.ts

@@ -69,6 +69,8 @@ async function generatePKCEPair(): Promise<{
   const codeVerifier = generateRandomString(32);
   const data = new TextEncoder().encode(codeVerifier);
   const hashed = await crypto.subtle.digest("SHA-256", data);
-  const codeChallenge = base64UrlEncode(new TextDecoder().decode(hashed));
+  const hashArray = Array.from(new Uint8Array(hashed));
+  const hashString = hashArray.map(b => String.fromCharCode(b)).join('');
+  const codeChallenge = base64UrlEncode(hashString);
   return { codeVerifier, codeChallenge };
 }