test: improvement to tests

Author: DanielRivers

lib/utils/checkAuth.test.ts

@@ -61,51 +61,20 @@ describe("checkAuth", () => {
     });
   });
 
-  // it.only('should use cookie refresh type when using custom domain and no _kbrte cookie', async () => {
-  //   vi.spyOn(refreshToken, "refreshToken").mockResolvedValue({
-  //     success: true,
-  //   });
-
-  //   const result = await checkAuth({ domain: "test.kinde.com", clientId });
-
-  //   expect(refreshToken.refreshToken).toHaveBeenCalledWith({
-  //     domain: "test.kinde.com",
-  //     clientId,
-  //     refreshType: refreshToken.RefreshType.refreshToken,
-  //   });
-  //   expect(result).toEqual({});
-  // });
-
-  // it('should use refresh token type when not using custom domain', async () => {
-  //   (refreshToken as vi.Mock).mockResolvedValue({} as RefreshTokenResult);
-
-  //   const result = await checkAuth({ domain: 'test.kinde.com', clientId });
-
-  //   expect(refreshToken).toHaveBeenCalledWith({
-  //     domain: 'not-custom.com',
-  //     clientId,
-  //     refreshType: RefreshType.refreshToken,
-  //   });
-  //   expect(result).toEqual({});
-  // });
-
-  // it('should use refresh token type when forceLocalStorage is true', async () => {
-  //   (refreshToken as vi.Mock).mockResolvedValue({} as RefreshTokenResult);
-
-  //   // Mock storageSettings to force local storage
-  //   const originalStorageSettings = storageSettings;
-  //   storageSettings.useInsecureForRefreshToken = true;
-
-  //   const result = await checkAuth({ domain, clientId });
-
-  //   expect(refreshToken).toHaveBeenCalledWith({
-  //     domain,
-  //     clientId,
-  //     refreshType: RefreshType.refreshToken,
-  //   });
-  //   expect(result).toEqual({});
-
-  //   // Restore original storageSettings
-  //   storageSettings.useInsecureForRefreshToken = originalStorageSettings.useInsecureForRefreshToken;
-  // });
+  it("error when domain supplied", async () => {
+    const result = await CheckAuth.checkAuth({ domain: null, clientId });
+     expect (result).toEqual({
+      success: false,
+      error: "Domain is required for authentication check",
+    });
+  });
+
+  it("error when clientId supplied", async () => {
+    const result = await CheckAuth.checkAuth({ domain, clientId: null });
+     expect (result).toEqual({
+      success: false,
+      error: "Client ID is required for authentication check",
+    });
+  });
+
 });

lib/utils/exchangeAuthCode.test.ts

@@ -409,9 +409,10 @@ describe("exchangeAuthCode", () => {
   });
 
   it("should return error if code verifier is missing", async () => {
-    const state = new MemoryStorage();
-    await state.setSessionItem(StorageKeys.state, "test");
-    setActiveStorage(state);
+    const store = new MemoryStorage();
+    await store.setSessionItem(StorageKeys.state, "test");
+    setActiveStorage(store);
+    
     const urlParams = new URLSearchParams();
     urlParams.append("state", "test");
     urlParams.append("code", "test");
@@ -444,16 +445,14 @@ describe("exchangeAuthCode", () => {
     });
     fetchMock.mockRejectOnce(new Error("Fetch failed"));
 
-    try {
-      await exchangeAuthCode({
+    await expect(
+      exchangeAuthCode({
         urlParams,
         domain: "test.com",
         clientId: "test",
         redirectURL: "test.com",
-      });
-    } catch (error) {
-      expect((error as Error).message).toBe("Fetch failed");
-    }
+      })
+    ).rejects.toThrow("Fetch failed");
   });
 
   it("should return error if token response is invalid", async () => {

lib/utils/getCookie.test.ts

@@ -84,4 +84,10 @@ describe("getCookie", () => {
     const result = getCookie("_kbrte");
     expect(result).toBeNull();
   });
+
+  it("should return null if parts.pop() returns undefined", () => {
+    document.cookie = "_kbrte=%E0%A4%A;path=/";
+    const result = getCookie("_kbrte");
+    expect(result).toBeNull();
+  });
 });

lib/utils/getCookie.ts

@@ -1,27 +1,16 @@
 export function getCookie(name: string): string | null {
-  const cookies = document.cookie.split(";");
-  for (let i = 0; i < cookies.length; i++) {
-    const cookie = cookies[i].trim();
-    if (cookie.startsWith(name + "=")) {
-      const cookieValue = cookie.substring(name.length + 1);
-      const parts = cookieValue.split(";");
-      let hasExpiration = false;
-      for (let j = 0; j < parts.length; j++) {
-        const part = parts[j].trim();
-        if (part.startsWith("expires=")) {
-          hasExpiration = true;
-          const expirationDate = new Date(part.substring(8));
-          if (expirationDate > new Date()) {
-            return cookieValue || null; // Cookie is valid
-          } else {
-            return null; // Cookie is expired
-          }
-        }
-      }
-      if (!hasExpiration) {
-        return cookieValue || null; // Cookie has no expiration, so it's valid
-      }
-    }
+  const cookies = document.cookie.split('; ');
+  console.log(cookies);
+  const cookieMatch = cookies.find(c => c.startsWith(`${name}=`));
+  
+  if (!cookieMatch) return null;
+  
+  try {
+    console.log('cookieMatch:', cookieMatch); 
+    const value = cookieMatch.split('=')[1];
+    return value ? decodeURIComponent(value) : null;
+  } catch (e) {
+    console.error(`Error parsing cookie ${name}:`, e);
+    return null;
   }
-  return null; // Cookie not found
 }