feat: add error when no sub in idtoken and getting user

Author: DanielRivers

lib/utils/token/getUserProfile.test.ts

@@ -1,4 +1,4 @@
-import { describe, expect, it, beforeEach } from "vitest";
+import { describe, expect, it, beforeEach, vi } from "vitest";
 import { MemoryStorage, StorageKeys } from "../../sessionManager";
 import { getUserProfile, setActiveStorage } from ".";
 import { createMockAccessToken } from "./testUtils";
@@ -53,4 +53,32 @@ describe("getUserProfile", () => {
       picture: "https://kinde.com/",
     });
   });
+
+  it("when no sub, return null", async () => {
+    await storage.setSessionItem(
+      StorageKeys.idToken,
+      createMockAccessToken({
+        sub: null,
+      }),
+    );
+    const idToken = await getUserProfile();
+
+    expect(idToken).toStrictEqual(null);
+  });
+
+  it("when no sub, return null", async () => {
+    const consoleMock = vi
+      .spyOn(console, "error")
+      .mockImplementation(() => undefined);
+
+    await storage.setSessionItem(
+      StorageKeys.idToken,
+      createMockAccessToken({
+        sub: null,
+      }),
+    );
+    await getUserProfile();
+
+    expect(consoleMock).toHaveBeenCalledWith("No sub in idToken");
+  });
 });

lib/utils/token/getUserProfile.ts

@@ -2,10 +2,10 @@ import { getDecodedToken } from ".";
 
 export type UserProfile = {
   id: string;
-  givenName: string;
-  familyName: string;
-  email: string;
-  picture: string;
+  givenName?: string;
+  familyName?: string;
+  email?: string;
+  picture?: string;
 };
 
 export const getUserProfile = async <T>(): Promise<
@@ -21,6 +21,11 @@ export const getUserProfile = async <T>(): Promise<
   if (!idToken) {
     return null;
   }
+  const { sub } = idToken;
+  if (!sub) {
+    console.error("No sub in idToken");
+    return null;
+  }
   return {
     id: idToken.sub,
     givenName: idToken.given_name,