Skip to content

Commit 296ca6f

Browse files
committed
Move searcher to filter area
The search function is now moved to filters area for more consistency Fix #554
1 parent d297432 commit 296ca6f

6 files changed

+22
-17
lines changed

resources/css/_contentManager.css

+2-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,8 @@ QMenu::item:selected {
6868
QLineEdit {
6969
font-family: 'Selawik';
7070
padding: 4px;
71-
border: 1px solid #cccccc;
71+
border: none;
72+
border-bottom: 1px solid #cccccc;
7273
color: #666666;
7374
font-size: 16px;
7475
height: 32px;

src/contentmanagerside.cpp

+12
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,18 @@ ContentManagerSide::ContentManagerSide(QWidget *parent) :
5454
}
5555
mp_contentManager->setCurrentContentTypeFilter(m_contentTypeFilters);
5656
});
57+
58+
auto searcher = mp_ui->searcher;
59+
searcher->setPlaceholderText(gt("search-files"));
60+
QFile file(QString::fromUtf8(":/css/_contentManager.css"));
61+
file.open(QFile::ReadOnly);
62+
QString styleSheet = QString(file.readAll());
63+
searcher->setStyleSheet(styleSheet);
64+
QIcon searchIcon = QIcon(":/icons/search.svg");
65+
searcher->addAction(searchIcon, QLineEdit::LeadingPosition);
66+
connect(searcher, &QLineEdit::textChanged, [searcher](){
67+
KiwixApp::instance()->getContentManager()->setSearch(searcher->text());
68+
});
5769

5870
ContentTypeFilter* videosFilter = new ContentTypeFilter("pictures", this);
5971
ContentTypeFilter* picturesFilter = new ContentTypeFilter("videos", this);

src/contentmanagerside.ui

+4-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
<property name="flat">
4747
<bool>true</bool>
4848
</property>
49-
<layout class="QVBoxLayout" name="verticalLayout_2" stretch="0,0,0,0,0,0,0,0,0">
49+
<layout class="QVBoxLayout" name="verticalLayout_2" stretch="0,0,0,0,0,0,0,0,0,0">
5050
<property name="spacing">
5151
<number>0</number>
5252
</property>
@@ -65,6 +65,9 @@
6565
<property name="bottomMargin">
6666
<number>0</number>
6767
</property>
68+
<item>
69+
<widget class="QLineEdit" name="searcher"/>
70+
</item>
6871
<item>
6972
<widget class="QRadioButton" name="allFileButton">
7073
<property name="sizePolicy">

src/contentmanagerview.cpp

-10
Original file line numberDiff line numberDiff line change
@@ -16,19 +16,9 @@ ContentManagerView::ContentManagerView(QWidget *parent)
1616
mp_ui->m_view->setContextMenuPolicy(Qt::CustomContextMenu);
1717
mp_ui->m_view->setCursor(Qt::PointingHandCursor);
1818

19-
auto searcher = mp_ui->searcher;
20-
searcher->setPlaceholderText(gt("search-files"));
21-
searcher->setStyleSheet(styleSheet);
22-
2319
loader = new KiwixLoader(mp_ui->loading);
2420
mp_ui->stackedWidget->setCurrentIndex(0);
2521

26-
QIcon searchIcon = QIcon(":/icons/search.svg");
27-
searcher->addAction(searchIcon, QLineEdit::LeadingPosition);
28-
29-
connect(searcher, &QLineEdit::textChanged, [searcher](){
30-
KiwixApp::instance()->getContentManager()->setSearch(searcher->text());
31-
});
3222
connect(mp_ui->m_view, &QTreeView::clicked, [=](QModelIndex index) {
3323
if (index.column() == (mp_ui->m_view->model()->columnCount() - 1))
3424
return;

src/contentmanagerview.h

-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ class ContentManagerView : public QWidget
1717
explicit ContentManagerView(QWidget *parent = nullptr);
1818
~ContentManagerView();
1919
QTreeView* getView() { return mp_ui->m_view; }
20-
QLineEdit* &getSearcher() { return mp_ui->searcher; }
2120

2221
public slots:
2322
void showLoader(bool show);

src/contentmanagerview.ui

+4-4
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,15 @@
1717
<item>
1818
<widget class="QStackedWidget" name="stackedWidget">
1919
<property name="currentIndex">
20-
<number>1</number>
20+
<number>0</number>
2121
</property>
2222
<widget class="QWidget" name="contents">
2323
<layout class="QVBoxLayout" name="verticalLayout_3">
2424
<item>
2525
<layout class="QVBoxLayout" name="verticalLayout">
26-
<item>
27-
<widget class="QLineEdit" name="searcher"/>
28-
</item>
26+
<property name="spacing">
27+
<number>0</number>
28+
</property>
2929
<item>
3030
<widget class="QTreeView" name="m_view"/>
3131
</item>

0 commit comments

Comments
 (0)