non-constant format string in call to (*testing.common).Errorf when running go test with go-1.24rc1

[rathann]

When running the tests under go-1.24rc1 (Fedora 42 pre-release branch), we get the following failure:

Testing    in: /builddir/build/BUILD/golang-github-klauspost-compress-1.17.11-build/compress-1.17.11/_build/src
         PATH: /builddir/build/BUILD/golang-github-klauspost-compress-1.17.11-build/compress-1.17.11/_build/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin
       GOPATH: /builddir/build/BUILD/golang-github-klauspost-compress-1.17.11-build/compress-1.17.11/_build:/usr/share/gocode
  GO111MODULE: off
      command: go test -buildmode pie -compiler gc -ldflags " -X github.com/klauspost/compress/version=1.17.11 -extldflags '-Wl,-z,relro -Wl,--as-needed  -Wl,-z,pack-relative-relocs -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -Wl,--build-id=sha1 -specs=/usr/lib/rpm/redhat/redhat-package-notes  '"
      testing: github.com/klauspost/compress
github.com/klauspost/compress
testing: warning: no tests to run
PASS
ok  	github.com/klauspost/compress	0.003s
github.com/klauspost/compress
testing: warning: no tests to run
PASS
ok  	github.com/klauspost/compress	0.003s
github.com/klauspost/compress/dict
?   	github.com/klauspost/compress/dict	[no test files]
github.com/klauspost/compress/flate
PASS
ok  	github.com/klauspost/compress/flate	19.933s
github.com/klauspost/compress/flate
PASS
ok  	github.com/klauspost/compress/flate	20.271s
github.com/klauspost/compress/fse
# github.com/klauspost/compress/fse
# [github.com/klauspost/compress/fse]
./fse_test.go:218:14: non-constant format string in call to (*testing.common).Errorf
./fse_test.go:243:15: non-constant format string in call to (*testing.common).Errorf
FAIL	github.com/klauspost/compress/fse [build failed]

[klauspost]

Sounds like you are running vet checks...

λ go version
go version go1.24.0 windows/amd64

λ go test .
ok      github.com/klauspost/compress/fse       0.383s

But might as well update CI and fix it.

[klauspost]

@rathann Ah. You are ignoring the go.mod version, so I guess you are deleting the go.mod.

I will fix it anyway, since it will come up in a year or two.

[klauspost]

Included in #1055