Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up: Remove NULL_DISPUTE_KIT references #1814

Closed
coderabbitai bot opened this issue Dec 20, 2024 · 1 comment
Closed

Follow-up: Remove NULL_DISPUTE_KIT references #1814

coderabbitai bot opened this issue Dec 20, 2024 · 1 comment

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 20, 2024

Follow-up to: #1813 (comment)
PR URL: #1813
Requested by: @jaybuidl

It appears that NULL_DISPUTE_KIT is still used for critical business logic in KlerosCoreBase. The constant is deprecated but removing it is non-trivial. This issue tracks the eventual removal or refactoring of NULL_DISPUTE_KIT references as part of a larger refactoring.

@jaybuidl
Copy link
Member

Putting this PR on hold because it would break the current production deployment after upgrade. It would require some dispute migration logic in the initializer and a fair amount of testing/simulation.

In addition the subgraph refers to the dispute kit classic index at 1 in a number of places.

Overall it's a high risk/low value change.

@jaybuidl jaybuidl closed this as not planned Won't fix, can't repro, duplicate, stale Mar 18, 2025
@jaybuidl jaybuidl removed their assignment Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant