Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add round and degreeOfCoherency info to the TokenAndETHShift event #586

Closed
jaybuidl opened this issue Feb 22, 2023 · 0 comments · Fixed by #585
Closed

Add round and degreeOfCoherency info to the TokenAndETHShift event #586

jaybuidl opened this issue Feb 22, 2023 · 0 comments · Fixed by #585
Assignees
Milestone

Comments

@jaybuidl
Copy link
Member

jaybuidl commented Feb 22, 2023

Blocking #264

Reposting from @alcercu's message on Slack

Problem

If in a dispute two jurors are penalized for being incoherent, both will get a 0 coherency score in the frontend, even if one were to have a higher degree of coherency than the other. In the end both were incoherent.

Solution

The best way to accomplish that would be to add a round field to the TokenAndETHShift . That will let me query the degree of coherency from the disputekit inside the subgraph (if we could add degreeOfCoherency to the event it would be event better, since querying contracts from the subgraph is quite slow, but I could manage without it, so not important). I think it will also give more context to this event, since there can be a lot of events from a single juror in a single disputes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants