Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart Contract Accounts support via ERC-1271 #833

Closed
Tracked by #1588
jaybuidl opened this issue May 15, 2023 · 3 comments · Fixed by #1638 or #1659
Closed
Tracked by #1588

Smart Contract Accounts support via ERC-1271 #833

jaybuidl opened this issue May 15, 2023 · 3 comments · Fixed by #1638 or #1659
Labels

Comments

@jaybuidl
Copy link
Member

jaybuidl commented May 15, 2023

Currently, smart contract accounts are able to stake in the court but

  • NOT able to authenticate via SIWE, so can't submit any evidence
  • NOT able to commit/reveal in courts where hiddenVotes are enabled.

We are planning to enable hiddenVotes in the General Court in v2.

Hidden votes are already enabled in the xDAI KlerosLiquid general court and both xDAI/Ethereum Spanish general court.

Resources

EIP1271

Commit/Reveal implementation in v1

@jaybuidl jaybuidl added Type: Feature🗿 Package: Contracts Court smart contracts Package: Web Court web frontend and removed Package: Contracts Court smart contracts labels May 15, 2023
@fnanni-0
Copy link
Contributor

Beware that some smart contract wallets like gnosis Safe don't support send() and transfer(). You can stake but won't get the arbitration fees.

@jaybuidl
Copy link
Member Author

jaybuidl commented Aug 4, 2023

Thanks @fnanni-0 that's good to know

@Harman-singh-waraich
Copy link
Contributor

As of this date:

  • Siwe verification works with Smart contract wallets (Gnosis Safe).
  • Committing works , Reveal has not been tested yet ( tested on localhost)

@jaybuidl jaybuidl linked a pull request Jul 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants