Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tokens): Updates for components after resizing (#DS-2168) #20

Merged
merged 17 commits into from
Jul 3, 2024

Conversation

vitalyozza
Copy link
Contributor

@vitalyozza vitalyozza commented Jun 25, 2024

A big update in which we've updated the tokens for fonts and corrected the tokens for various components.

Works in pair with
koobiq/angular-components#99

Figma with new styles
https://www.figma.com/design/y44d4NE7WYcbE9jQicsyIg/branch/eUkmWM9qmLT70jYmAtzL9G/koobiq-%C2%B7-PT-2023?m=auto&node-id=34417-229121&t=GCaEG7noAgE9Gvu6-1

@vitalyozza vitalyozza self-assigned this Jun 25, 2024
@vitalyozza vitalyozza changed the title Feat/ds 2168 update font sizes feat(tokens): Updates for components after resizing (#DS-2168) Jun 25, 2024
@rmnturov rmnturov requested a review from lskramarov June 26, 2024 06:41
@rmnturov rmnturov marked this pull request as ready for review June 26, 2024 06:41
@@ -216,13 +219,16 @@
'margin-left': { value: '{size.xxs}' }
}
},
'vertical-padding': { value: '{size.xxs}' },
'vertical-padding': { value: '{size.3xs}' },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vitalyozza убери паддинг, плиз, раз ввел высоту. Лёня сказал, что исправит SCSS. Будет отталкиваться от высоты

vitalyozza and others added 17 commits July 3, 2024 13:12

Verified

This commit was signed with the committer’s verified signature.
lukebond Luke Bond

Verified

This commit was signed with the committer’s verified signature.
lukebond Luke Bond

Verified

This commit was signed with the committer’s verified signature.
lukebond Luke Bond

Verified

This commit was signed with the committer’s verified signature.
lukebond Luke Bond

Verified

This commit was signed with the committer’s verified signature.
lukebond Luke Bond
@lskramarov lskramarov force-pushed the feat/DS-2168-Update-Font-Sizes branch from f9517a7 to f76554a Compare July 3, 2024 10:24
@lskramarov lskramarov merged commit a61a7fa into main Jul 3, 2024
1 check passed
@lskramarov lskramarov deleted the feat/DS-2168-Update-Font-Sizes branch July 3, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants