Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: removed card component tokens #35

Merged
merged 2 commits into from
Aug 14, 2024
Merged

feat: removed card component tokens #35

merged 2 commits into from
Aug 14, 2024

Conversation

artembelik
Copy link
Contributor

No description provided.

@artembelik artembelik requested a review from rmnturov August 8, 2024 14:36
@artembelik
Copy link
Contributor Author

artembelik commented Aug 8, 2024 •
edited
Loading

https://github.com/koobiq/design-tokens/blob/main/packages/design-tokens/web/properties/colors.json5#L53

@rmnturov @pimenovoleg @NikGurev нужно ли это удалять?
этот токен много где используется

@pimenovoleg
Copy link
Contributor

@artembelik
Давай тут реализуем только удаление токенов card, скрипты инфраструктуры поправим отдельно.

@NikGurev
Copy link
Contributor

NikGurev commented Aug 9, 2024

@artembelik нужно ревью от дизайна, навскидку не скажу
Могу только сказать, что использование много где могло остаться как результат , когда один токен был не готов, но значение было нужно
Поэтому нужно определить, намеренно ли использование этого токена или же по незнанию

@rmnturov
Copy link
Contributor

rmnturov commented Aug 9, 2024

https://github.com/koobiq/design-tokens/blob/main/packages/design-tokens/web/properties/colors.json5#L53

@rmnturov @pimenovoleg @NikGurev нужно ли это удалять? этот токен много где используется

Этот токен удалять не надо

@rmnturov
Copy link
Contributor

rmnturov commented Aug 9, 2024

Уточню задачу. Удалить надо компонент Card и страницу о нем в доках. Токен backgroud/card удалять не надо → он используется во всплывашках

@artembelik artembelik requested a review from lskramarov August 13, 2024 08:06
@pimenovoleg pimenovoleg removed their request for review August 14, 2024 08:52
@artembelik artembelik merged commit 5d6caaf into main Aug 14, 2024
1 check passed
@artembelik artembelik deleted the feat/DS-2534 branch August 14, 2024 09:11
sk8knut added a commit that referenced this pull request Sep 10, 2024
@sk8knut
Merge branch 'main' into feat/DS-2629
e629b1b 
* main:
  chore: bump version to 3.5.0 w/ changelog
  feat(colors): added new tokens and updated contrast-fade for our lines (#46)
  chore: bump version to 3.4.0 w/ changelog
  feat: shadows and subtle divider (#DS-2175) (#45)
  chore: bump version to 3.3.1 w/ changelog
  fix(typography): font-weight for strong (#DS-2762) (#43)
  chore: bump version to 3.3.0 w/ changelog
  feat: Сontrast Сollibration (#DS-2003) (#38)
  feat(tooltip): updated tokens (#41)
  chore: bump version to 3.2.0 w/ changelog
  feat: transformed theme-specific global vars to theme-agnostic (#DS-2755) (#42)
  chore: bump version to 3.1.0 w/ changelog
  feat: removed card component tokens (#35)
  feat: support composite typography tokens (#39)
  feat: added eslint recommended plugin (#36)
  fix(typography): strong weight 500 → 600 (#DS-2741) (#37)
  chore: bump version to 3.0.0 w/ changelog
  fix(calendar): selected item color in dark theme (#DS-2685) (#32)
  fix(popover): header padding bottom (#DS-2723) #33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lskramarov lskramarov lskramarov approved these changes

@rmnturov rmnturov rmnturov approved these changes

@NikGurev NikGurev NikGurev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@artembelik @pimenovoleg @NikGurev @rmnturov @lskramarov