Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: transformed theme-specific global vars to theme-agnostic (#DS-2755) #42

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

NikGurev
Copy link
Contributor

Theming unified

Global semantic colors have been placed under theme selectors and prefixes for variables removed - so they do not depend on the theme. For example:

Before

// css-tokens.css
--kbq-light-theme-default: color;
--kbq-dark-theme-default: otherColor;

After

// css-tokens-light.css
.kbq-light {
   --kbq-theme-default: color;
   ... other theme specific colors
}
// css-tokens-dark.css
.kbq-light {
   --kbq-theme-default: otherColor;
   ... other theme specific colors
}

@NikGurev NikGurev added the enhancement New feature or request label Aug 15, 2024
@NikGurev NikGurev self-assigned this Aug 15, 2024
@pimenovoleg pimenovoleg merged commit b1428d5 into main Aug 15, 2024
2 checks passed
@pimenovoleg pimenovoleg deleted the feat/DS-2755 branch August 15, 2024 17:11
sk8knut added a commit that referenced this pull request Sep 10, 2024
* main:
  chore: bump version to 3.5.0 w/ changelog
  feat(colors): added new tokens and updated contrast-fade for our lines (#46)
  chore: bump version to 3.4.0 w/ changelog
  feat: shadows and subtle divider (#DS-2175) (#45)
  chore: bump version to 3.3.1 w/ changelog
  fix(typography): font-weight for strong (#DS-2762) (#43)
  chore: bump version to 3.3.0 w/ changelog
  feat: Сontrast Сollibration (#DS-2003) (#38)
  feat(tooltip): updated tokens (#41)
  chore: bump version to 3.2.0 w/ changelog
  feat: transformed theme-specific global vars to theme-agnostic (#DS-2755) (#42)
  chore: bump version to 3.1.0 w/ changelog
  feat: removed card component tokens (#35)
  feat: support composite typography tokens (#39)
  feat: added eslint recommended plugin (#36)
  fix(typography): strong weight 500 → 600 (#DS-2741) (#37)
  chore: bump version to 3.0.0 w/ changelog
  fix(calendar): selected item color in dark theme (#DS-2685) (#32)
  fix(popover): header padding bottom (#DS-2723) #33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants